Merge pull request #155 from fastlane/lk/fix-platform-not-found

Do not use platform before it's initialized

Author: lfkellogg

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -23,11 +23,9 @@ def self.run(params)
 
         if params[:app] # Set app_id if it is specified as a parameter
           app_id = params[:app]
-        elsif platform == :ios
-          archive_path = Actions.lane_context[SharedValues::XCODEBUILD_ARCHIVE]
-          if archive_path
-            app_id = get_ios_app_id_from_archive_plist(archive_path, params[:googleservice_info_plist_path])
-          end
+        elsif xcode_archive_path
+          plist_path = params[:googleservice_info_plist_path]
+          app_id = get_ios_app_id_from_archive_plist(xcode_archive_path, plist_path)
         end
         if app_id.nil?
           UI.crash!(ErrorMessage::MISSING_APP_ID)
@@ -68,6 +66,14 @@ def self.details
         "Release your beta builds with Firebase App Distribution"
       end
 
+      def self.xcode_archive_path
+        # prevents issues on cross-platform build environments where an XCode build happens within
+        # the same lane
+        return nil if lane_platform == :android
+
+        Actions.lane_context[SharedValues::XCODEBUILD_ARCHIVE]
+      end
+
       def self.lane_platform
         Actions.lane_context[Actions::SharedValues::PLATFORM_NAME]
       end

spec/firebase_app_distribution_action_spec.rb

@@ -1,3 +1,5 @@
+require 'fastlane/action'
+
 describe Fastlane::Actions::FirebaseAppDistributionAction do
   let(:action) { Fastlane::Actions::FirebaseAppDistributionAction }
   describe '#platform_from_app_id' do
@@ -35,4 +37,26 @@
       expect(action.binary_path_from_platform(nil, nil, nil)).to eq(nil)
     end
   end
+
+  describe '#xcode_archive_path' do
+    it 'returns the archive path is set, and platform is not Android' do
+      allow(Fastlane::Actions).to receive(:lane_context).and_return({
+        XCODEBUILD_ARCHIVE: '/path/to/archive'
+      })
+      expect(action.xcode_archive_path).to eq('/path/to/archive')
+    end
+
+    it 'returns nil if platform is Android' do
+      allow(Fastlane::Actions).to receive(:lane_context).and_return({
+        XCODEBUILD_ARCHIVE: '/path/to/archive',
+        PLATFORM_NAME: :android
+      })
+      expect(action.xcode_archive_path).to be_nil
+    end
+
+    it 'returns nil if the archive path is not set' do
+      allow(Fastlane::Actions).to receive(:lane_context).and_return({})
+      expect(action.xcode_archive_path).to be_nil
+    end
+  end
 end