Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability in testing scenarios - unhandled promise rejections #54

Open
NandoTheessen opened this issue Jan 10, 2019 · 0 comments
Open

Comments

@NandoTheessen
Copy link

NandoTheessen commented Jan 10, 2019

Hey @nicolasgarnier !

I've been using your component for a hot minute, implementing OAuth in an app I'm contributing to.

There are 2 unhandled promise rejections in this plugin that will automatically fail in a test environment where .env variables are missing.

Is there a special way this plugin should be tested?
If not would it be feasible to implement a catch for each of the 2 used promises in order for it not to have to be mocked out completely?

I tested it in a fork locally and it works like a charm for me, if I should open a PR for this, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant