Skip to content

fix(py): implement SigV4 signing for AWS X-Ray OTLP exporter #141

fix(py): implement SigV4 signing for AWS X-Ray OTLP exporter

fix(py): implement SigV4 signing for AWS X-Ray OTLP exporter #141

Workflow file for this run

# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# SPDX-License-Identifier: Apache-2.0
name: TODO Lint
on:
pull_request:
branches: [main, next]
push:
branches: [main, next]
jobs:
todo-lint:
name: Check TODO Format
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Check for plain TODOs without issue links
run: |
#!/usr/bin/env bash
set -euo pipefail
echo "Checking for TODO comments without issue links..."
echo "=============================================="
# Find all TODOs without proper issue references
# Proper formats:
# # TODO(https://github.com/firebase/genkit/issues/1234): Description
# # TODO(#1234): Description
# Invalid format:
# # TODO: Description
# First, find all TODOs
ALL_TODOS=$(grep -rn '#[[:space:]]*TODO' \
--include="*.py" \
--exclude-dir=".venv" \
--exclude-dir=".tox" \
--exclude-dir="node_modules" \
--exclude-dir=".mypy_cache" \
--exclude-dir="__pycache__" \
--exclude-dir="dist" \
--exclude-dir="build" \
py/ 2>/dev/null || true)
# Filter out valid TODOs (those with issue references)
# Valid: TODO(#NNN) or TODO(https://...)
BAD_TODOS=$(echo "$ALL_TODOS" | grep -v 'TODO(#[0-9]\+)' | grep -v 'TODO(https://' || true)
if [ -n "$BAD_TODOS" ]; then
echo "❌ Found TODO comments without issue links:"
echo ""
echo "$BAD_TODOS"
echo ""
echo "=============================================="
echo "TODOs must include a GitHub issue reference for tracking."
echo ""
echo "Correct formats:"
echo " # TODO(#1234): Description"
echo " # TODO(https://github.com/firebase/genkit/issues/1234): Description"
echo ""
echo "Wrong format:"
echo " # TODO: Description"
echo ""
echo "Please create GitHub issues for each TODO and update the format."
exit 1
fi
echo "✅ All TODOs have proper issue links!"