Skip to content

Commit cce12b6

Browse files
committed
tweak the participants header bar in the packets list
- extract labels into locales - rename to PacketsParticipantsBar - add bottom border and box shadow to the header bar - change proposed labels to: Actors (Server) and Toolbox (Client)
1 parent 36060f8 commit cce12b6

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

chrome/locale/en-US/inspector.properties

+5
Original file line numberDiff line numberDiff line change
@@ -84,3 +84,8 @@ rdpInspector.menu.File=File
8484
rdpInspector.menu.Options=Options
8585
rdpInspector.cmd.load=Load
8686
rdpInspector.cmd.save=Save
87+
88+
# LOCALIZATION NOTE (rdpInspector.label.serverParticipant, rdpInspector.label.clientParticipant):
89+
# Labels for the participant header bar in the packets panel main area.
90+
rdpInspector.label.serverParticipant=Actors
91+
rdpInspector.label.clientParticipant=Toolbox

data/inspector/components/packets-panel.js

+11-8
Original file line numberDiff line numberDiff line change
@@ -19,32 +19,35 @@ const { Splitter } = require("./splitter");
1919
// Shortcuts
2020
const { DIV, SPAN } = Reps.DOM;
2121

22-
var PacketsDirectionsBar = React.createClass({
23-
/** @lends PacketsDirectionsBar */
22+
var PacketsParticipantsBar = React.createClass({
23+
/** @lends PacketsParticipantsBar */
2424

25-
displayName: "PacketsDirectionsBar",
25+
displayName: "PacketsParticipantsBar",
2626

2727
render: function() {
2828
return DIV({
29-
id: "packetsDirectionsBar",
29+
id: "packetsParticipantsBar",
3030
style: {
3131
position: "relative",
32-
height: "24px"
32+
height: "24px",
33+
borderBottom: "1px solid #aaaaaa",
34+
boxShadow: "0px 2px 2px 0px #aaaaaa",
35+
zIndex: "1000"
3336
}
3437
}, SPAN({ style: {
3538
position: "absolute",
3639
top: "0px",
3740
left: "10px",
3841
fontWeight: "bold",
3942
fontSize: "1.2em"
40-
}, key: "server"}, "Server"),
43+
}, key: "serverParticipant"}, Locale.$STR("rdpInspector.label.serverParticipant")),
4144
SPAN({ style: {
4245
position: "absolute",
4346
top: "0px",
4447
right: "10px",
4548
fontWeight: "bold",
4649
fontSize: "1.2em"
47-
}, key: "client"}, "Client")
50+
}, key: "clientParticipant"}, Locale.$STR("rdpInspector.label.clientParticipant"))
4851
);
4952
}
5053
});
@@ -72,7 +75,7 @@ var PacketsPanel = React.createClass({
7275
packetCacheEnabled: this.props.packetCacheEnabled,
7376
paused: this.props.paused
7477
}),
75-
React.createElement(PacketsDirectionsBar, {}),
78+
React.createElement(PacketsParticipantsBar, {}),
7679
PacketList({
7780
data: this.props.packets,
7881
actions: this.props.actions,

0 commit comments

Comments
 (0)