Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use GuestMemory::read_from() and GuestMemory::write_to() in Vsock #2592

Closed
serban300 opened this issue May 27, 2021 · 2 comments
Closed

use GuestMemory::read_from() and GuestMemory::write_to() in Vsock #2592

serban300 opened this issue May 27, 2021 · 2 comments
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Type: Fix Indicates a fix to existing code

Comments

@serban300
Copy link
Contributor

As part of #2574 we refactored vsock in order to use vm-memory methods instead of raw pointers. For performance reasons and limitations related to our vm-memory wrapper crate we used GuestMemoryRegion::read_from() and GuestMemoryRegion::write_to()

After dirty bitmap tracking is merged in rust-vmm/vm-memory we should be able to use GuestMemory::read_from() and GuestMemory::write_to() directly.
@serban300 serban300 added Quality: Improvement Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` labels May 27, 2021
@serban300 serban300 mentioned this issue May 27, 2021
Merged
9 tasks
@serban300 serban300 mentioned this issue Aug 19, 2021
Merged
9 tasks
@alindima
Copy link
Contributor

While the performance aspect is fixed by #2661 , this issue is blocked by: rust-vmm/vm-memory#171

@JonathanWoollett-Light JonathanWoollett-Light added Type: Fix Indicates a fix to existing code and removed Quality: Improvement labels Mar 24, 2023
@roypat
Copy link
Contributor

roypat commented May 31, 2023

With #3653 this no longer applies

@roypat roypat closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Type: Fix Indicates a fix to existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alindima @JonathanWoollett-Light @serban300 @roypat