RieszMap boundary condition fixes

Author: jrmaddison

firedrake/cofunction.py

@@ -426,6 +426,13 @@ def __init__(self, function_space_or_inner_product=None,
                     sobolev_space, u, v
                 )
 
+        if bcs is None:
+            bcs = ()
+        else:
+            bcs = tuple(bcs)
+        if len(bcs) > 0 and inner_product == "l2":
+            raise ValueError("Cannot supply boundary conditions with an l2 Riesz map")
+
         self._function_space = function_space
         self._inner_product = inner_product
         self._bcs = bcs
@@ -490,8 +497,13 @@ def __call__(self, value):
                 for o, c in zip(output.subfunctions, value.subfunctions):
                     o.dat.data[:] = c.dat.data_ro[:]
             else:
+                if len(self._bcs) > 0:
+                    value = value.copy(deepcopy=True)
+                    for bc in self._bcs:
+                        bc.apply(value)
                 output = firedrake.assemble(
-                    firedrake.action(self._inner_product, value)
+                    firedrake.action(self._inner_product, value),
+                    bcs=self._bcs, zero_bc_nodes=True,
                 )
         else:
             raise ValueError(