-
Notifications
You must be signed in to change notification settings - Fork 174
Firedrake meeting 2023 11 22
Connor Ward edited this page Nov 23, 2023
·
16 revisions
Date and time 2023-11-22 1600 GMT (1600 UTC)
- Pick Chair and Minuter (RNH to pick minuter)
- ALL: (ongoing) triage the open issues and confirm if they are indeed still open (and perhaps provide labels)
- JB: Move pyop3 and FInAT to firedrakeproject
- ALL: do things with SV's branches
- DH: Email to Andreas to have 2 (+ others!!!) loopy PRs merged TODO: FIND OUT WHICH PRS THESE ARE
- DH: Get Firedrake a docker open source account (link here)
- DH: Talk to GregVernon about PR#2116.
- DH: Revisit PR#2484.
- DH: Order more Firedrake stickers
- ALL/ANY: Drop libsupermesh (minutes)? JB: Waiting for https://github.com/Toblerity/rtree/pull/292
- NB: Look for changes needed to manual to account for dual spaces
Present: CW (minuter), DD, JB, KS, DH, RNH, PB, NB, JHC, IM, FA
Apologies:
- JB: PETSc errors are getting raised in
PetscFinalizein the Firedrake pyadjoint tests. - JB: Solution should be able to catch this in future.
- DD: Issue is somehow related to pytest-xdist (i.e.
pytest -n ???). - Action point DD: Investigate further.
- DH: No guarantees are made for the ordering between checkpoint files and meshes. To make comparisons one needs to load the mesh from the checkpoint.
- DH: Could possibly use interpolation to get this to work. One can take a spanning DG space and interpolate into it.
- DH: If FE definitions changes (e.g. PB changing Lagrange) then these guarantees do not hold. One could add a check here where we do an interpolation and make sure that the interpolation matrix is the identity.
This is PR 3117 below. CW suggests this is worth wider discussion.
- CW: This is currently an API change since plotting functions would no longer be in the
from firedrake import *. - DH: We should replace the moved functions in the global namespace with functions that raise a hard error and point users to the right function to call.
- DH: We could follow the same approach for making VTK optional.
- DH: Could have a policy that external dependencies should be truly optional.
This is PR 3152 below. CW suggests this is worth wider discussion. JB thinks this should really only be a semi-public interface, excessive calls to this functionality will be disastrous for performance!
- DH: Fine for GC routines to be out of the public namespace.
- DH:
garbage_cleanupshould crash if a communicator is not found. - DH: Let's keep the
atexitcomm cleanup stuff. No real reason to get rid of it.
See below.
and apparently, Xcode15 has sorted this issue.
See the PR 3249
JB and I were trying to move the documentation for numpydoc format.
Merged, build is fixed. The transition to numpydoc remains outstanding.
- PB: FIAT #54 - merged
- PB: FInAT #115 - merged
- PB: MG easy fix - merged
- PB: reconstruct FunctionSpace - feedback given,
MixedFunctionSpaces can contain primal and dual spaces - JHC: sort FormSum.coefficients - merged
- JB: #3117 Separate out Matplotlib - see discussion above
- JB: #3152 A public interface to the garbage collector (for those who really want one, not that I am encouraging anyone to actually use it!): - see discussion above
- Look at in this order: #3152, #3229, PyOP2 #711, PyOP2 #712
- Needs merging in this order: #3229, PyOP2 #712, PyOP2 #711, #3152
- PB: HypreAMS easy fix
- KS: #3174
- DD: #3239 - merged
- DD: #3250
- JHC: 3235 - more discussion/thought required
1600 GMT (1600 UTC) 2023-11-29