Merge pull request #77 from fivetran/bug/issue-enhanced-nulls

bug/issue-enhanced-nulls

Author: fivetran-catfritz

.github/pull_request_template.md

@@ -28,9 +28,9 @@
 
 **How did you test the PR changes?** 
 <!--- Proof of testing is required in order for the PR to be approved. -->
-<!--- To check a box, remove the space and insert an x in the box (eg. [x] CircleCi). --> 
+<!--- To check a box, remove the space and insert an x in the box (eg. [x] Buildkite). --> 
 <!--- To select a checkbox you simply need to add an "x" with no spaces between the brackets (eg. [x] Yes). -->
-- [ ] CircleCi <!--- CircleCi testing is only applicable to Fivetran employees. --> 
+- [ ] Buildkite <!--- Buildkite testing is only applicable to Fivetran employees. --> 
 - [ ] Local (please provide additional testing details below)
 
 **Select which warehouse(s) were used to test the PR**

CHANGELOG.md

@@ -1,10 +1,19 @@
+# dbt_jira v0.10.1
+## ❗Please Note❗
+- While this is a patch update, it may also require a full refresh. Please run `dbt run --full-refresh` after upgrading to ensure you have the latest incremental logic.
+## 🐞 Bug Fix
+- Updated logic for model `int_jira__issue_sprint` to further adjust how current sprint is determined. It now uses a combination of the newest `updated_at` date for the issue and the newest `started_at` date of the sprint. This is to account for times when jira updates two sprint records at the same time. ([#77](https://github.com/fivetran/dbt_jira/pull/77) and [#78](https://github.com/fivetran/dbt_jira/pull/78))
+## Contributors
+- [@jingyu-spenmo](https://github.com/jingyu-spenmo) ([#78](https://github.com/fivetran/dbt_jira/pull/78))
+
+
 # dbt_jira v0.10.0
 
 ## 🚨 Breaking Changes
-For model `jira__issue_enhanced`, updated column names `sprint_id` and `sprint_name` to `current_sprint_id` and `current_sprint_name`, respectively, to confirm the record is for the current sprint. ([#76](https://github.com/fivetran/dbt_jira/pull/76))
+- For model `jira__issue_enhanced`, updated column names `sprint_id` and `sprint_name` to `current_sprint_id` and `current_sprint_name`, respectively, to confirm the record is for the current sprint. ([#76](https://github.com/fivetran/dbt_jira/pull/76))
 
 ## 🐞 Bug Fix
-Updated logic for model `int_jira__issue_sprint` to adjust how current sprint is determined. It now uses the newest `started_at` date of the sprint instead of the `updated_at` date. ([#76](https://github.com/fivetran/dbt_jira/pull/76))
+- Updated logic for model `int_jira__issue_sprint` to adjust how current sprint is determined. It now uses the newest `started_at` date of the sprint instead of the `updated_at` date. ([#76](https://github.com/fivetran/dbt_jira/pull/76))
 
 # dbt_jira v0.9.0
 ## 🚨 Breaking Changes 🚨

dbt_project.yml

@@ -1,5 +1,5 @@
 name: 'jira'
-version: '0.10.0'
+version: '0.10.1'
 config-version: 2
 require-dbt-version: [">=1.0.0", "<2.0.0"]
 

docs/catalog.json

@@ -1,12 +1,12 @@
 name: 'jira_integration_tests'
-version: '0.10.0'
+version: '0.10.1'
 config-version: 2
 profile: 'integration_tests'
 
 
 vars:
-  jira_schema: jira_integration_tests
   jira_source:
+    jira_schema: jira_integration_tests
     comment: "{{ ref('comment') }}"
     component: "{{ ref('component') }}"
     epic: "{{ ref('epic') }}"

docs/manifest.json

@@ -19,15 +19,17 @@ sprint_field_history as (
 
     select 
         field_history.*,
+        sprint.*,
         row_number() over (
                     partition by field_history.issue_id 
-                    order by sprint.started_at desc
+                    order by field_history.updated_at desc, sprint.started_at desc         
                     ) as row_num
     from field_history
-    left join sprint on field_history.field_value = cast(sprint.sprint_id as {{dbt_utils.type_string()}})
+    join sprint on field_history.field_value = cast(sprint.sprint_id as {{dbt_utils.type_string()}})
     where lower(field_history.field_name) = 'sprint'
 ),
 
+
 last_sprint as (
 
     select *
@@ -53,18 +55,17 @@ issue_sprint as (
     select 
         last_sprint.issue_id,
         last_sprint.field_value as current_sprint_id,
-        sprint.sprint_name as current_sprint_name,
-        sprint.board_id,
-        sprint.started_at as sprint_started_at,
-        sprint.ended_at as sprint_ended_at,
-        sprint.completed_at as sprint_completed_at,
+        last_sprint.sprint_name as current_sprint_name,
+        last_sprint.board_id,
+        last_sprint.started_at as sprint_started_at,
+        last_sprint.ended_at as sprint_ended_at,
+        last_sprint.completed_at as sprint_completed_at,
         coalesce(sprint_rollovers.count_sprint_changes, 0) as count_sprint_changes
 
     from 
     last_sprint 
-    join sprint on last_sprint.field_value = cast(sprint.sprint_id as {{dbt_utils.type_string()}})
     left join sprint_rollovers on sprint_rollovers.issue_id = last_sprint.issue_id
 
 )
 
-select * from issue_sprint
+select * from issue_sprint