Merge pull request #37 from fivetran/fix/field-history-partition

Partition by fix within field history models

Author: fivetran-joemarkiewicz

README.md

@@ -29,7 +29,7 @@ Check [dbt Hub](https://hub.getdbt.com/) for the latest installation instruction
 # packages.yml
 packages:
   - package: fivetran/jira
-    version: [">=0.4.0", "<0.5.0"]
+    version: [">=0.5.0", "<0.6.0"]
 ```
 
 ## Configuration

dbt_project.yml

@@ -1,5 +1,5 @@
 name: 'jira'
-version: '0.4.0'
+version: '0.5.0'
 config-version: 2
 require-dbt-version: ">=0.20.0"
 

integration_tests/dbt_project.yml

@@ -1,5 +1,5 @@
 name: 'jira_integration_tests'
-version: '0.4.0'
+version: '0.5.0'
 config-version: 2
 profile: 'integration_tests'
 

models/intermediate/field_history/int_jira__field_history_scd.sql

@@ -17,8 +17,8 @@ with change_data as (
         {% for col in issue_columns if col.name|lower not in ['valid_starting_on','issue_id','issue_day_id'] %} 
         , {{ col.name }}
         -- create a batch/partition once a new value is provided
-        , sum( case when {{ col.name }} is null then 0 else 1 end) over (
-            order by issue_id, valid_starting_on rows unbounded preceding) as {{ col.name }}_field_partition
+        , sum( case when {{ col.name }} is null then 0 else 1 end) over ( partition by issue_id 
+            order by valid_starting_on rows unbounded preceding) as {{ col.name }}_field_partition
 
         {% endfor %}
 
@@ -37,7 +37,7 @@ with change_data as (
 
         -- grab the value that started this batch/partition
         , first_value( {{ col.name }} ) over (
-            partition by {{ col.name }}_field_partition 
+            partition by issue_id, {{ col.name }}_field_partition 
             order by valid_starting_on asc rows between unbounded preceding and current row) as {{ col.name }}
 
         {% endfor %}

models/jira__daily_issue_field_history.sql

@@ -85,8 +85,8 @@ set_values as (
         {% for col in pivot_data_columns if col.name|lower not in ['issue_id','issue_day_id','valid_starting_on'] %}
         , {{ col.name }}
         -- create a batch/partition once a new value is provided
-        , sum( case when {{ col.name }} is null then 0 else 1 end) over (
-            order by issue_id, date_day rows unbounded preceding) as {{ col.name }}_field_partition
+        , sum( case when {{ col.name }} is null then 0 else 1 end) over ( partition by issue_id
+            order by date_day rows unbounded preceding) as {{ col.name }}_field_partition
 
         {% endfor %}
 
@@ -102,7 +102,7 @@ fill_values as (
         {% for col in pivot_data_columns if col.name|lower not in ['issue_id','issue_day_id','valid_starting_on'] %}
         -- grab the value that started this batch/partition
         , first_value( {{ col.name }} ) over (
-            partition by {{ col.name }}_field_partition 
+            partition by issue_id, {{ col.name }}_field_partition 
             order by date_day asc rows between unbounded preceding and current row) as {{ col.name }}
         {% endfor %}