Skip to content

Commit c2d0a39

Browse files
fivetran-joemarkiewiczfivetran-data-model-botfivetran-catfritzfivetran-jamiegithub-actions[bot]
authored
bugfix/empty-actor-id (#76)
* bugfix/empty-actor-id * changelog pr ref * Q2 FY26 Automatic Package Updates (#73) * Q2 FY26: Apply automated update. * Q2 FY26: Update auto-release workflow only. --------- Co-authored-by: fivetran-catfritz <[email protected]> Co-authored-by: Joe Markiewicz <[email protected]> * Update integration_tests/seeds/ticket_chat_event_data.csv * review updates * empty string handling * Update CHANGELOG.md Co-authored-by: Jamie Rodriguez <[email protected]> * changelog update * Generate dbt docs via GitHub Actions --------- Co-authored-by: Fivetran Maintainer Bot <[email protected]> Co-authored-by: fivetran-catfritz <[email protected]> Co-authored-by: Jamie Rodriguez <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent b603a3b commit c2d0a39

File tree

13 files changed

+133
-32
lines changed

13 files changed

+133
-32
lines changed

.github/PULL_REQUEST_TEMPLATE/maintainer_pull_request_template.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,15 @@ Before marking this PR as "ready for review":
1212

1313
## PR Overview
1414
**Package version introduced in this PR:**
15-
15+
-
16+
1617
**This PR addresses the following Issue/Feature(s):**
1718
<!-- Add Issue # or internal ticket reference -->
19+
-
1820

1921
**Summary of changes:**
2022
<!-- 1-2 sentences describing PR changes. -->
21-
23+
-
2224

2325
### Submission Checklist
2426
- [ ] Alignment meeting with the reviewer (if needed)
@@ -27,9 +29,10 @@ Before marking this PR as "ready for review":
2729
- [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests)
2830
- [ ] **Testing Instructions:** Confirm the change addresses the issue(s)
2931
- [ ] **Focus Areas:** Complex logic or queries that need extra attention
32+
- [ ] Merge any relevant open PRs into this PR
3033

3134
### Changelog
3235
<!-- Recommend drafting changelog notes, then refining via ChatGPT using:
3336
"Draft a changelog entry based on the following notes." -->
3437
- [ ] Draft changelog for PR
35-
- [ ] Final changelog for release review
38+
- [ ] Final changelog for release review

.github/workflows/auto-release.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@ on:
33
pull_request:
44
types:
55
- closed
6-
branches:
7-
- main
6+
- labeled
87

98
jobs:
10-
call-workflow-passing-data:
11-
if: github.event.pull_request.merged
9+
release:
10+
if: |
11+
(github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'main') ||
12+
github.event.label.name == 'pre-release'
1213
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main
13-
secrets: inherit
14+
secrets: inherit
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: 'generate dbt docs'
2+
on:
3+
pull_request:
4+
types:
5+
- labeled
6+
7+
jobs:
8+
generate-docs:
9+
if: github.event.label.name == 'docs:ready'
10+
uses: fivetran/dbt_package_automations/.github/workflows/generate-docs.yml@main
11+
secrets: inherit
12+
with:
13+
schema_var_name: zendesk_schema

.gitignore

Lines changed: 70 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,73 @@
1-
2-
target/
1+
# dbt
2+
**/package-lock.yml
3+
package-lock.yml
4+
.dbt/
35
dbt_modules/
6+
dbt_packages/
47
logs/
8+
profiles.yml
9+
target/
10+
*.log
11+
12+
# IDE files
13+
.idea/
14+
.vscode/
15+
*~
16+
*.swp
17+
*.swo
18+
19+
# Jupyter Notebook
20+
.ipynb_checkpoints
21+
22+
# OS generated files
23+
**/.DS_Store
524
.DS_Store
6-
dbt_packages/
7-
env/
25+
.Spotlight-V100
26+
.Trashes
27+
._*
28+
Thumbs.db
29+
ehthumbs.db
30+
31+
# Python
32+
*.egg
33+
*.egg-info/
34+
*.py[cod]
35+
*.so
36+
*$py.class
37+
.Python
38+
__pycache__/
39+
build/
40+
develop-eggs/
41+
dist/
42+
downloads/
43+
eggs/
44+
.env
45+
.installed.cfg
46+
lib/
47+
lib64/
48+
MANIFEST
49+
parts/
50+
sdist/
51+
var/
52+
wheels/
53+
54+
# Secrets and credentials
55+
.env.*
56+
.secrets
57+
credentials.json
58+
service-account.json
59+
60+
# Temporary files
61+
.cache/
62+
*.temp
63+
*.tmp
64+
65+
# Virtual environments
66+
.conda/
67+
.env
68+
.venv
69+
ENV/
70+
env/
71+
env.bak/
72+
venv/
73+
venv.bak/

CHANGELOG.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
# dbt_zendesk_source v0.18.2
2+
3+
## Bug Fix
4+
[PR #76](https://github.com/fivetran/dbt_zendesk_source/pull/76) includes the following updates:
5+
- Updated `actor_id` extraction in `stg_zendesk__ticket_chat_event` to handle edge cases where the value is `agent:` with no ID or an empty string (` `). Now using a nullif condition to cast missing IDs as `null`, ensuring consistent typing and preventing model compilation errors across warehouses.
6+
- In addition to the nullif update, these records are also filtered out of the final staging model as they are not relevant for downstream use.
7+
8+
### Under the Hood - July 2025 Updates
9+
[PR #73](https://github.com/fivetran/dbt_zendesk_source/pull/73) includes the following updates:
10+
- Updated conditions in `.github/workflows/auto-release.yml`.
11+
- Added `.github/workflows/generate-docs.yml`.
12+
- Added `+docs: show: False` to `integration_tests/dbt_project.yml`.
13+
- Migrated `flags` (e.g., `send_anonymous_usage_stats`, `use_colors`) from `sample.profiles.yml` to `integration_tests/dbt_project.yml`.
14+
- Updated `maintainer_pull_request_template.md` with improved checklist.
15+
- Updated `.gitignore` to exclude additional DBT, Python, and system artifacts.
16+
117
# dbt_zendesk_source v0.18.1
218

319
[PR #72](https://github.com/fivetran/dbt_zendesk_source/pull/72) includes the following updates:

README.md

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,11 @@
55
href="https://github.com/fivetran/dbt_zendesk_source/blob/main/LICENSE">
66
<img src="https://img.shields.io/badge/License-Apache%202.0-blue.svg" /></a>
77
<a alt="dbt-core">
8-
<img src="https://img.shields.io/badge/dbt_Core™_version->=1.3.0_<2.0.0-orange.svg" /></a>
8+
<img src="https://img.shields.io/badge/dbt_Core™_version->=1.3.0_,<2.0.0-orange.svg" /></a>
99
<a alt="Maintained?">
1010
<img src="https://img.shields.io/badge/Maintained%3F-yes-green.svg" /></a>
1111
<a alt="PRs">
1212
<img src="https://img.shields.io/badge/Contributions-welcome-blueviolet" /></a>
13-
<a alt="Fivetran Quickstart Compatible"
14-
href="https://fivetran.com/docs/transformations/dbt/quickstart">
15-
<img src="https://img.shields.io/badge/Fivetran_Quickstart_Compatible%3F-yes-green.svg" /></a>
1613
</p>
1714

1815
## What does this dbt package do?
@@ -94,7 +91,7 @@ sources:
9491
database: <database_name>
9592
loader: fivetran
9693
loaded_at_field: _fivetran_synced
97-
94+
9895
freshness: # feel free to adjust to your liking
9996
warn_after: {count: 72, period: hour}
10097
error_after: {count: 168, period: hour}
@@ -182,11 +179,11 @@ models:
182179
zendesk_source:
183180
+schema: my_new_schema_name # leave blank for just the target_schema
184181
```
185-
182+
186183
### Change the source table references (only if using a single connection)
187184
If an individual source table has a different name than the package expects, add the table name as it appears in your destination to the respective variable. This is not available when running the package on multiple unioned connections.
188185
> IMPORTANT: See this project's [dbt_project.yml](https://github.com/fivetran/dbt_zendesk_source/blob/main/dbt_project.yml) variable declarations to see the expected names.
189-
186+
190187
```yml
191188
vars:
192189
zendesk_<default_source_table_name>_identifier: your_table_name
@@ -207,10 +204,10 @@ vars:
207204
### (Optional) Step 6: Orchestrate your models with Fivetran Transformations for dbt Core™
208205
<details><summary>Expand to view details</summary>
209206
<br>
210-
207+
211208
Fivetran offers the ability for you to orchestrate your dbt project through [Fivetran Transformations for dbt Core™](https://fivetran.com/docs/transformations/dbt). Learn how to set up your project for orchestration through Fivetran in our [Transformations for dbt Core™ setup guides](https://fivetran.com/docs/transformations/dbt#setupguide).
212209
</details>
213-
210+
214211
## Does this package have dependencies?
215212
This dbt package is dependent on the following dbt packages. These dependencies are installed by default within this package. For more information on the following packages, refer to the [dbt hub](https://hub.getdbt.com/) site.
216213
> IMPORTANT: If you have any of these dependent packages in your own `packages.yml` file, we highly recommend that you remove them from your root `packages.yml` to avoid package version conflicts.
@@ -225,7 +222,7 @@ packages:
225222
- package: dbt-labs/spark_utils
226223
version: [">=0.3.0", "<0.4.0"]
227224
```
228-
225+
229226
## How is this package maintained and can I contribute?
230227
### Package Maintenance
231228
The Fivetran team maintaining this package _only_ maintains the latest version of the package. We highly recommend that you stay consistent with the [latest version](https://hub.getdbt.com/fivetran/zendesk_source/latest/) of the package and refer to the [CHANGELOG](https://github.com/fivetran/dbt_zendesk_source/blob/main/CHANGELOG.md) and release notes for more information on changes across versions.

dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
config-version: 2
22
name: 'zendesk_source'
3-
version: '0.18.1'
3+
version: '0.18.2'
44
require-dbt-version: [">=1.3.0", "<2.0.0"]
55

66
models:

docs/catalog.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

docs/manifest.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

integration_tests/ci/sample.profiles.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ integration_tests:
4545
host: "{{ env_var('CI_DATABRICKS_DBT_HOST') }}"
4646
http_path: "{{ env_var('CI_DATABRICKS_DBT_HTTP_PATH') }}"
4747
schema: zendesk_source_integrations_tests_7
48-
threads: 2
48+
threads: 8
4949
token: "{{ env_var('CI_DATABRICKS_DBT_TOKEN') }}"
5050
type: databricks

0 commit comments

Comments
 (0)