Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fails when "do_not_skip" contains "merge_group" #332

Closed
mbaumanndev opened this issue Oct 19, 2023 · 3 comments
Closed

Workflow fails when "do_not_skip" contains "merge_group" #332

mbaumanndev opened this issue Oct 19, 2023 · 3 comments

Comments

@mbaumanndev
Copy link

mbaumanndev commented Oct 19, 2023

Hello,

I have a workflow with the following do_not_skip value:

do_not_skip: '["workflow_dispatch", "schedule", "merge_group"]'

When starting, I get the following error:

Error: Elements in 'do_not_skip' must be one of "pull_request", "push", "workflow_dispatch", "schedule", "release"

Here is my complete configuration for this action:

name: Code checks

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]
  merge_group:
    branches: [ master ]

concurrency:
  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
  cancel-in-progress: true

jobs:
  queue:
    runs-on: ubuntu-latest
    if: github.event.pull_request.draft == false

    outputs:
      should_skip: ${{ steps.skip.outputs.should_skip }}
      paths_result: ${{ steps.skip.outputs.paths_result }}

    steps:
      - id: skip
        uses: fkirc/skip-duplicate-actions@v5
        with:
          concurrent_skipping: "same_content_newer"
          cancel_others: true
          skip_after_successful_duplicate: true
          do_not_skip: '["workflow_dispatch", "schedule", "merge_group"]'
          paths: '["front/**", "server/**", ".github/workflows/code-checks.yml"]'
          paths_filter: |
            front:
              paths:
                - "front/**"
            server:
              paths:
                - "server/**"
            ci:
              paths:
                - ".github/workflows/code-checks.yml"
@paescuj
Copy link
Collaborator

paescuj commented Oct 19, 2023

This is because #329 hasn't been released yet. You can use fkirc/skip-duplicate-actions@master in the meantime but I highly encourage you to switch back to a tag afterwards.

@paescuj paescuj closed this as completed Oct 19, 2023
@mbaumanndev
Copy link
Author

I think this shoud be told in the README, I thought it was released because it's mentionned there.

@fkirc
Copy link
Owner

fkirc commented Oct 21, 2023

I made a new release that includes the fix: https://github.com/fkirc/skip-duplicate-actions/releases/tag/v5.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants