Skip to content

MLA returns NaN when kvcache for unfilled tokens in the last page is NaN #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abcdabcd987 opened this issue Mar 13, 2025 · 1 comment
Closed

MLA returns NaN when kvcache for unfilled tokens in the last page is NaN #941

abcdabcd987 opened this issue Mar 13, 2025 · 1 comment
Assignees
@yzh119

Comments

@abcdabcd987
Copy link
Member

For example, when page size is 4 and kv length is 13, the last page is not full. For those unused tokens, if the kvcache is NaN, the output would be NaN.

See the attached test case.

https://gist.github.com/abcdabcd987/9fc81c0323a538953ab3a793e78c9f57
@yzh119
Copy link
Collaborator

yzh119 commented Mar 14, 2025

Seems related to #942

@yzh119 yzh119 mentioned this issue Mar 14, 2025
Merged
yzh119 added a commit that referenced this issue Mar 14, 2025
@yzh119
bugfix: fix potential issues of FA3 template loading nans for PageAtt…
061db55 
…ention (#945)

Ref #941
@yzh119 yzh119 closed this as completed Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yzh119 yzh119

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abcdabcd987 @yzh119