Flatpak Node Generator Fails with ValueError: Unknown playwright browser chromium-headless-shell

[x80486]

flatpak-builder version

N/A

Linux distribution and version

Debian Bookworm

Affected flatpak-builder tool

node/flatpak-node-generator.py

flatpak-builder tool cli args

No response

Source repository URL

https://github.com/heyman/heynote.git

Flatpak-builder manifest URL

N/A

Description

I'm trying to see if Heynote could be built as Flatpak. I started using the flatpak-node-generator tool to generate the sources for the offline build, but it's always failing with this error message:

Generating packages [498/499] electron @ 33.3.1Traceback (most recent call last):
38.23   File "/root/.cache/pipx/029f774ef16802a/bin/flatpak-node-generator", line 8, in <module>
38.23 
38.23     sys.exit(main())
38.23              ^^^^^^
38.23   File "/root/.cache/pipx/029f774ef16802a/lib/python3.11/site-packages/flatpak_node_generator/main.py", line 277, in main
38.23     asyncio.run(_async_main())
38.23   File "/usr/lib/python-build-standalone/3.11/lib/python3.11/asyncio/runners.py", line 190, in run
38.23     return runner.run(main)
38.23            ^^^^^^^^^^^^^^^^
38.23   File "/usr/lib/python-build-standalone/3.11/lib/python3.11/asyncio/runners.py", line 118, in run
38.23     return self._loop.run_until_complete(task)
38.23            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
38.23   File "/usr/lib/python-build-standalone/3.11/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
38.23     return future.result()
38.23            ^^^^^^^^^^^^^^^
38.23   File "/root/.cache/pipx/029f774ef16802a/lib/python3.11/site-packages/flatpak_node_generator/main.py", line 229, in _async_main
38.23     await progress.run()
38.23   File "/root/.cache/pipx/029f774ef16802a/lib/python3.11/site-packages/flatpak_node_generator/progress.py", line 78, in run
38.23     await coro
38.23   File "/usr/lib/python-build-standalone/3.11/lib/python3.11/asyncio/tasks.py", line 605, in _wait_for_one
38.23     return f.result()  # May raise f.exception().
38.23            ^^^^^^^^^^
38.23   File "/root/.cache/pipx/029f774ef16802a/lib/python3.11/site-packages/flatpak_node_generator/progress.py", line 68, in _generate
38.23     await self.module_provider.generate_package(package)
38.23   File "/root/.cache/pipx/029f774ef16802a/lib/python3.11/site-packages/flatpak_node_generator/providers/npm.py", line 365, in generate_package
38.23     await self.special_source_provider.generate_special_sources(package)
38.23   File "/root/.cache/pipx/029f774ef16802a/lib/python3.11/site-packages/flatpak_node_generator/providers/special.py", line 482, in generate_special_sources
38.23     await self._handle_playwright(package)
38.23   File "/root/.cache/pipx/029f774ef16802a/lib/python3.11/site-packages/flatpak_node_generator/providers/special.py", line 370, in _handle_playwright
38.23     raise ValueError(f'Unknown playwright browser {name}')
38.23 ValueError: Unknown playwright browser chromium-headless-shell

I'm not quite familiar with Python, so I'm running flatpak-node-generator with PIPX (1.7.x):

$ git clone https://github.com/flatpak/flatpak-builder-tools.git
$ pipx install /path/to/flatpak-builder-tools/node/
$ git clone --branch v2.1.1 --single-branch https://github.com/heyman/heynote.git
$ pipx run flatpak-node-generator npm heynote/package-lock.json

[martinetd]

I worked around the issue by making it pretend it's chromium

Also webkit failed too and bumping to ubutun 22.04 seemed to go further:

diff --git a/node/flatpak_node_generator/providers/special.py b/node/flatpak_node_generator/providers/special.py
index 3427641c567c..3406a602411d 100644
--- a/node/flatpak_node_generator/providers/special.py
+++ b/node/flatpak_node_generator/providers/special.py
@@ -351,6 +351,9 @@ class SpecialSourceProvider:
                 else:
                     url_tp = 'https://playwright.azureedge.net/builds/chromium/%d/%s'
                     dl_file = 'chromium-linux.zip'
+            elif name == "chromium-headless-shell":
+                url_tp = 'https://playwright.azureedge.net/builds/chromium/%d/%s'
+                dl_file = 'chromium-linux.zip'
             elif name == 'firefox':
                 url_tp = 'https://playwright.azureedge.net/builds/firefox/%d/%s'
                 if revision < 1140:
@@ -362,7 +365,8 @@ class SpecialSourceProvider:
                 if revision < 1317:
                     dl_file = 'minibrowser-gtk-wpe.zip'
                 else:
-                    dl_file = 'webkit-ubuntu-20.04.zip'
+                    # revision 2140 did not have webkit-ubuntu-20.04.zip
+                    dl_file = 'webkit-ubuntu-22.04.zip'
             elif name == 'ffmpeg':
                 url_tp = 'https://playwright.azureedge.net/builds/ffmpeg/%d/%s'
                 dl_file = 'ffmpeg-linux.zip'

I don't care enough to open a PR, sorry -- feel free to do whatever you want with the above diff.