Skip to content

Commit 2bf9f64

Browse files
committed
Group UI improvements
1 parent edd37c3 commit 2bf9f64

File tree

3 files changed

+43
-18
lines changed

3 files changed

+43
-18
lines changed

etc/css/style.css

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@
7272
--ui-blue-30: rgba(79, 149, 255, 0.30);
7373

7474
--steel-transparent-96: rgb(26, 29, 35, 0.96);
75-
--steel-transparent-90: rgb(26, 29, 35, 0.80);
75+
--steel-transparent-80: rgb(26, 29, 35, 0.80);
76+
77+
--steel-transparent-dark: rgb(46, 50, 60, 0.30);
7678
--steel-transparent-light: rgb(46, 50, 60, 0.85);
7779

7880
/* Color assignments */
@@ -94,6 +96,7 @@
9496
--row-bg: var(--steel-800);
9597
--cell-bg: var(--steel-transparent-96);
9698
--cell-bg-hover: var(--steel-transparent-light);
99+
--cell-header-bg: var(--steel-transparent-dark);
97100

98101
--primary-text: var(--grey-100);
99102
--secondary-text: var(--grey-400);
@@ -1042,7 +1045,13 @@ div.query-results-nav {
10421045
justify-content: flex-end;
10431046
background-color: var(--panel-footer-bg);
10441047
padding-top: 3px;
1048+
padding-bottom: 3px;
10451049
padding-right: 6px;
1050+
border-style: solid;
1051+
border-width: 1px;
1052+
border-left-width: 0px;
1053+
border-right-width: 0px;
1054+
border-color: var(--grey-900);
10461055
}
10471056

10481057
div.query-results-nav span {
@@ -1361,7 +1370,7 @@ div.content-status-visible {
13611370

13621371
div.content-status-body {
13631372
display: flex;
1364-
background-color: var(--steel-transparent-90);
1373+
background-color: var(--steel-transparent-80);
13651374
color: var(--footer-text);
13661375
width: calc(100% - 3px);
13671376
margin-left: 3px;
@@ -1452,6 +1461,7 @@ tr.query-results-group-row {
14521461

14531462
tr.query-results-group-separator td {
14541463
height: 3px !important;
1464+
background-color: var(--steel-800) !important;
14551465
}
14561466

14571467
td.query-results-group {

etc/js/query.js

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -126,17 +126,21 @@ Vue.component('query', {
126126
this.$emit("panel-update");
127127
},
128128
on_prev() {
129-
this.offset -= this.limit;
130-
if (this.offset < 0) {
131-
this.offset = 0;
129+
if (this.has_prev) {
130+
this.offset -= this.limit;
131+
if (this.offset < 0) {
132+
this.offset = 0;
133+
}
134+
this.update_page();
135+
this.refresh();
132136
}
133-
this.update_page();
134-
this.refresh();
135137
},
136138
on_next() {
137-
this.offset += this.limit;
138-
this.update_page();
139-
this.refresh();
139+
if (this.has_next) {
140+
this.offset += this.limit;
141+
this.update_page();
142+
this.refresh();
143+
}
140144
},
141145
on_limit(evt) {
142146
this.limit = parseInt(evt.target.value);
@@ -275,12 +279,18 @@ Vue.component('query', {
275279
ref="page"
276280
v-on:keyup.enter="on_page"
277281
v-on:blur="on_page"></input>
278-
<button :disabled="!has_prev" v-on:click="on_prev" class="noselect">
279-
Previous
280-
</button>
281-
<button :disabled="!has_next" v-on:click="on_next" class="noselect">
282-
Next
283-
</button>
282+
<icon-button
283+
icon="codicons:chevron-left"
284+
:size="28"
285+
:active="has_prev"
286+
:opacity="0.7"
287+
v-on:click="on_prev"></icon-button>
288+
<icon-button
289+
icon="codicons:chevron-right"
290+
:size="28"
291+
:active="has_next"
292+
:opacity="0.7"
293+
v-on:click="on_next"></icon-button>
284294
</div>
285295
</template>
286296
</template>

etc/js/query_results.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ Vue.component('query-results-table', {
251251
let i = 0;
252252

253253
for (let el of this.columns.data.index) {
254-
const var_cur = el.order_by;
254+
const var_cur = el.label;
255255
if ((var_cur !== var_last)) {
256256
if (var_groups.length) {
257257
var_groups[var_groups.length - 1].count =
@@ -629,10 +629,15 @@ Vue.component('query-results', {
629629
} else if (this.order_by.kind === 'var') {
630630
let index = 0;
631631
const order_by_value = result.vars[this.order_by.index];
632+
let label = result.var_labels[this.order_by.index];
633+
if (label === 0) {
634+
label = result.vars[this.order_by.index];
635+
}
632636
for (let i = 0; i < (result.entities.length || 1); i ++) {
633637
r.data.index.push({
634638
index: index + r.count,
635-
order_by: order_by_value
639+
order_by: order_by_value,
640+
label: label
636641
});
637642
index ++;
638643
}

0 commit comments

Comments
 (0)