fix: incorrect positioning of non-FAB controls assigned to page.floating_action_button (#5049)

* fab can be of any type

* cleanup

Author: ndonkoHenri

packages/flet/lib/src/controls/markdown.dart

@@ -10,7 +10,6 @@ import '../utils/box.dart';
 import '../utils/images.dart';
 import '../utils/launch_url.dart';
 import '../utils/markdown.dart';
-import '../utils/text.dart';
 import '../utils/uri.dart';
 import 'create_control.dart';
 import 'error.dart';

packages/flet/lib/src/controls/page.dart

@@ -874,9 +874,7 @@ class _ViewControlState extends State<ViewControl> with FletStoreMixin {
               control.attrString("horizontalAlignment"),
               CrossAxisAlignment.start)!;
           final fabLocation = parseFloatingActionButtonLocation(
-              control,
-              "floatingActionButtonLocation",
-              FloatingActionButtonLocation.endFloat);
+              control, "floatingActionButtonLocation");
 
           Control? appBar;
           Control? cupertinoAppBar;
@@ -898,18 +896,18 @@ class _ViewControlState extends State<ViewControl> with FletStoreMixin {
             } else if (ctrl.type == "bottomappbar") {
               bottomAppBar = ctrl;
               continue;
-            } else if (ctrl.type == "floatingactionbutton") {
+            } else if (ctrl.name == "fab") {
               fab = ctrl;
               continue;
             } else if (ctrl.type == "navigationbar" ||
                 ctrl.type == "cupertinonavigationbar") {
               navBar = ctrl;
               continue;
             } else if (ctrl.type == "navigationdrawer" &&
-                ctrl.name == "start") {
+                ctrl.name == "drawer_start") {
               drawer = ctrl;
               continue;
-            } else if (ctrl.type == "navigationdrawer" && ctrl.name == "end") {
+            } else if (ctrl.type == "navigationdrawer" && ctrl.name == "drawer_end") {
               endDrawer = ctrl;
               continue;
             }

packages/flet/lib/src/utils/buttons.dart

@@ -95,8 +95,8 @@ ButtonStyle? buttonStyleFromJSON(ThemeData theme, Map<String, dynamic>? json,
   );
 }
 
-FloatingActionButtonLocation parseFloatingActionButtonLocation(
-    Control control, String propName, FloatingActionButtonLocation defValue) {
+FloatingActionButtonLocation? parseFloatingActionButtonLocation(
+    Control control, String propName, [FloatingActionButtonLocation? defValue]) {
   const Map<String, FloatingActionButtonLocation> fabLocations = {
     "centerdocked": FloatingActionButtonLocation.centerDocked,
     "centerfloat": FloatingActionButtonLocation.centerFloat,

sdk/python/packages/flet/src/flet/core/view.py

@@ -122,14 +122,15 @@ def _get_children(self):
         if self.__bottom_appbar:
             children.append(self.__bottom_appbar)
         if self.__fab:
+            self.__fab._set_attr_internal("n", "fab")
             children.append(self.__fab)
         if self.__navigation_bar:
             children.append(self.__navigation_bar)
         if self.__drawer:
-            self.__drawer._set_attr_internal("n", "start")
+            self.__drawer._set_attr_internal("n", "drawer_start")
             children.append(self.__drawer)
         if self.__end_drawer:
-            self.__end_drawer._set_attr_internal("n", "end")
+            self.__end_drawer._set_attr_internal("n", "drawer_end")
             children.append(self.__end_drawer)
         return children + self.__controls