Make flet build work in CI environment (#4993)

* Do not force terminal in CI environment

* Use sh/cmd.exe with "yes" to run sdk manager

* Install more Android SDKs and tools

* Fix Windows android installation

* Fix windows Android SDK installation

* Fix Windows android installation, again

* Fix again

* Another try

* Finally fixed?

* encoding="utf-8"

* Try echo y

* Remove input from processes.run

* Output plain-text status in non-terminal

* Flet version bumped to 0.27.3

* Escape sdk manager path

Author: FeodorFitsner

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Flet changelog
 
+## 0.27.3
+
+* Fixes to make `flet build` work in CI environment ([#4993](https://github.com/flet-dev/flet/issues/4993))
+
 ## 0.27.2
 
 * Error on second flet build run "Because {app} depends on flet_{package} from path which doesn't exist" ([#4955](https://github.com/flet-dev/flet/issues/4955))

packages/flet/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.27.3
+
+* Fixes to make `flet build` work in CI environment ([#4993](https://github.com/flet-dev/flet/issues/4993))
+
 # 0.27.2
 
 * Error on second flet build run "Because {app} depends on flet_{package} from path which doesn't exist" ([#4955](https://github.com/flet-dev/flet/issues/4955))

packages/flet/pubspec.yaml

@@ -2,7 +2,7 @@ name: flet
 description: Write entire Flutter app in Python or add server-driven UI experience into existing Flutter app.
 homepage: https://flet.dev
 repository: https://github.com/flet-dev/flet/packages/flet
-version: 0.27.2
+version: 0.27.3
 
 # This package supports all platforms listed below.
 platforms:

sdk/python/packages/flet-cli/src/flet_cli/commands/build.py

@@ -38,9 +38,15 @@
 
 MINIMAL_FLUTTER_VERSION = version.Version("3.27.4")
 
+no_rich_output = get_bool_env_var("FLET_CLI_NO_RICH_OUTPUT")
+
 error_style = Style(color="red", bold=True)
 warning_style = Style(color="yellow", bold=True)
-console = Console(log_path=False, theme=Theme({"log.message": "green bold"}))
+console = Console(
+    log_path=False,
+    theme=Theme({"log.message": "green bold"}),
+    force_terminal=not no_rich_output,
+)
 verbose1_style = Style(dim=True, bold=False)
 verbose2_style = Style(color="bright_black", bold=False)
 
@@ -79,7 +85,7 @@ def __init__(self, parser: argparse.ArgumentParser) -> None:
         self.flutter_packages_temp_dir = None
         self.flutter_exe = None
         self.skip_flutter_doctor = get_bool_env_var("FLET_CLI_SKIP_FLUTTER_DOCTOR")
-        self.no_rich_output = get_bool_env_var("FLET_CLI_NO_RICH_OUTPUT")
+        self.no_rich_output = no_rich_output
         self.current_platform = platform.system()
         self.platforms = {
             "windows": {
@@ -725,7 +731,7 @@ def flutter_version_valid(self):
         return False
 
     def install_flutter(self):
-        self.status.update(
+        self.update_status(
             f"[bold blue]Installing Flutter {MINIMAL_FLUTTER_VERSION}..."
         )
         from flet_cli.utils.flutter import install_flutter
@@ -773,7 +779,7 @@ def install_flutter(self):
     def install_jdk(self):
         from flet_cli.utils.jdk import install_jdk
 
-        self.status.update(f"[bold blue]Installing JDK...")
+        self.update_status(f"[bold blue]Installing JDK...")
         jdk_dir = install_jdk(self.log_stdout, progress=self.progress)
         self.env["JAVA_HOME"] = jdk_dir
 
@@ -806,7 +812,7 @@ def install_jdk(self):
     def install_android_sdk(self):
         from flet_cli.utils.android_sdk import AndroidSDK
 
-        self.status.update(f"[bold blue]Installing Android SDK...")
+        self.update_status(f"[bold blue]Installing Android SDK...")
         self.env["ANDROID_HOME"] = AndroidSDK(
             self.env["JAVA_HOME"], self.log_stdout, progress=self.progress
         ).install()
@@ -1207,7 +1213,7 @@ def create_flutter_project(self, second_pass=False):
             # create a new Flutter bootstrap project directory, if non-existent
             if not second_pass:
                 self.flutter_dir.mkdir(parents=True, exist_ok=True)
-                self.status.update(
+                self.update_status(
                     f'[bold blue]Creating Flutter bootstrap project from {template_url} with ref "{template_ref}"...'
                 )
 
@@ -1262,7 +1268,7 @@ def register_flutter_extensions(self):
             shutil.move(self.flutter_packages_temp_dir, self.flutter_packages_dir)
 
         if self.flutter_packages_dir.exists():
-            self.status.update(f"[bold blue]Registering Flutter user extensions...")
+            self.update_status(f"[bold blue]Registering Flutter user extensions...")
 
             for fp in os.listdir(self.flutter_packages_dir):
                 if (self.flutter_packages_dir / fp / "pubspec.yaml").exists():
@@ -1401,7 +1407,7 @@ def customize_icons(self):
         if hash.has_changed():
 
             if copy_ops:
-                self.status.update(f"[bold blue]Customizing app icons...")
+                self.update_status(f"[bold blue]Customizing app icons...")
                 for op in copy_ops:
                     if self.verbose > 0:
                         console.log(
@@ -1416,7 +1422,7 @@ def customize_icons(self):
             ]
             self.save_yaml(self.pubspec_path, updated_pubspec)
 
-            self.status.update(f"[bold blue]Generating app icons...")
+            self.update_status(f"[bold blue]Generating app icons...")
 
             # icons
             icons_result = self.run(
@@ -1632,7 +1638,7 @@ def customize_splash_images(self):
         if hash.has_changed():
 
             if copy_ops:
-                self.status.update(f"[bold blue]Customizing app splash images...")
+                self.update_status(f"[bold blue]Customizing app splash images...")
                 for op in copy_ops:
                     if self.verbose > 0:
                         console.log(
@@ -1646,7 +1652,7 @@ def customize_splash_images(self):
             self.save_yaml(self.pubspec_path, updated_pubspec)
 
             # splash screens
-            self.status.update(f"[bold blue]Generating splash screens...")
+            self.update_status(f"[bold blue]Generating splash screens...")
             splash_result = self.run(
                 [
                     self.dart_exe,
@@ -1690,7 +1696,7 @@ def package_python_app(self):
 
         hash = HashStamp(self.build_dir / ".hash" / "package")
 
-        self.status.update(f"[bold blue]Packaging Python app...")
+        self.update_status(f"[bold blue]Packaging Python app...")
         package_args = [
             self.dart_exe,
             "run",
@@ -1905,7 +1911,7 @@ def flutter_build(self):
         assert self.get_pyproject
         assert self.template_data
 
-        self.status.update(
+        self.update_status(
             f"[bold blue]Building [cyan]{self.platforms[self.options.target_platform]['status_text']}[/cyan]..."
         )
         # flutter build
@@ -2021,7 +2027,7 @@ def copy_build_output(self):
         assert self.out_dir
         assert self.assets_path
 
-        self.status.update(
+        self.update_status(
             f"[bold blue]Copying build to [cyan]{self.rel_out_dir}[/cyan] directory...",
         )
         arch = platform.machine().lower()
@@ -2148,6 +2154,12 @@ def run_flutter_doctor(self):
         if flutter_doctor.returncode == 0 and flutter_doctor.stdout:
             console.log(flutter_doctor.stdout, style=verbose1_style)
 
+    def update_status(self, status):
+        if self.no_rich_output:
+            console.log(status)
+        else:
+            self.status.update(status)
+
     def log_stdout(self, message):
         if self.verbose > 0:
             console.log(

sdk/python/packages/flet-cli/src/flet_cli/utils/android_sdk.py

@@ -159,10 +159,26 @@ def _install_package(self, home_dir: Path, package_name: str) -> int:
             return 0
 
         self.log(f'Installing Android SDK package "{package_name}"')
+
         p = self.run(
-            [self.sdkmanager_exe(home_dir), package_name],
+            (
+                [
+                    "sh",
+                    "-c",
+                    f'yes | "{self.sdkmanager_exe(home_dir)}" "{package_name}"',
+                ]
+                if platform.system() != "Windows"
+                else [
+                    "cmd.exe",
+                    "/C",
+                    "echo",
+                    "y",
+                    "|",
+                    self.sdkmanager_exe(home_dir),
+                    package_name,
+                ]
+            ),
             env={"ANDROID_HOME": str(home_dir)},
-            input="y\n" * 10,
             capture_output=False,
         )
         if p.returncode != 0:
@@ -172,13 +188,22 @@ def _install_package(self, home_dir: Path, package_name: str) -> int:
 
     def _accept_licenses(self, home_dir: Path):
         self.log("Accepting Android SDK licenses")
+
         p = self.run(
-            [
-                self.sdkmanager_exe(home_dir),
-                "--licenses",
-            ],
+            (
+                ["sh", "-c", f'yes | "{self.sdkmanager_exe(home_dir)}" --licenses']
+                if platform.system() != "Windows"
+                else [
+                    "cmd.exe",
+                    "/C",
+                    "echo",
+                    "y",
+                    "|",
+                    self.sdkmanager_exe(home_dir),
+                    "--licenses",
+                ]
+            ),
             env={"ANDROID_HOME": str(home_dir)},
-            input="y\n" * 20,
             capture_output=False,
         )
         if p.returncode != 0:
@@ -199,7 +224,7 @@ def get_installed_packages(self, home_dir: Path):
             )
         return p.stdout
 
-    def run(self, args, env=None, cwd=None, input=None, capture_output=True):
+    def run(self, args, env=None, cwd=None, capture_output=True):
 
         self.log(f"Run subprocess: {args}")
 
@@ -214,7 +239,6 @@ def run(self, args, env=None, cwd=None, input=None, capture_output=True):
             args,
             cwd if cwd else os.getcwd(),
             env=cmd_env,
-            input=input,
             capture_output=capture_output,
             log=self.log,
         )

sdk/python/packages/flet-cli/src/flet_cli/utils/processes.py

@@ -8,9 +8,7 @@
     from ctypes import windll
 
 
-def run(
-    args, cwd, env: Optional[dict] = None, input=None, capture_output=True, log=None
-):
+def run(args, cwd, env: Optional[dict] = None, capture_output=True, log=None):
     if is_windows():
         # Source: https://stackoverflow.com/a/77374899/1435891
         # Save the current console output code page and switch to 65001 (UTF-8)
@@ -29,9 +27,9 @@ def run(
             cwd=cwd,
             capture_output=True,
             text=True,
-            encoding="utf8",
+            encoding="utf-8",
             env=cmd_env,
-            errors="replace"
+            errors="replace",
         )
     else:
         process = subprocess.Popen(
@@ -41,15 +39,9 @@ def run(
             stdout=subprocess.PIPE,
             stderr=subprocess.STDOUT,
             text=True,
-            encoding="utf8",
+            encoding="utf-8",
             env=cmd_env,
-            errors="replace"
-        )
-
-        input_iterator = (
-            iter(input)
-            if isinstance(input, list)
-            else iter(input.split("\n")) if isinstance(input, str) else iter([])
+            errors="replace",
         )
 
         try:
@@ -60,16 +52,6 @@ def run(
                 if stdout_line and log:
                     log(stdout_line.rstrip())
 
-                # Check if process is waiting for input
-                if process.poll() is None and process.stdin:
-                    try:
-                        next_input = next(input_iterator) + "\n"
-                        process.stdin.write(next_input)
-                        process.stdin.flush()
-                    except StopIteration:
-                        # If no more input, close stdin to signal end
-                        process.stdin.close()
-
                 # Break when the process ends and buffers are empty
                 if not stdout_line and process.poll() is not None:
                     break