Icons-browser v2 with page-level locks

Author: FeodorFitsner

sdk/python/flet/page.py

@@ -48,6 +48,7 @@ def __init__(self, conn: Connection, session_id):
         self._last_event = None
         self._event_available = threading.Event()
         self._fetch_page_details()
+        self.lock = threading.Lock()
 
         self.__offstage = Offstage()
         self.__theme = None

sdk/python/playground/icons-browser.py

@@ -1,4 +1,6 @@
+import logging
 import os
+from itertools import islice
 
 import flet
 from flet import (
@@ -18,7 +20,7 @@
     icons,
 )
 
-# logging.basicConfig(level=logging.DEBUG)
+# logging.basicConfig(level=logging.INFO)
 
 # fetch all icon constants from icons.py module
 icons_list = []
@@ -32,6 +34,12 @@
 os.environ["FLET_WS_MAX_MESSAGE_SIZE"] = "8000000"
 
 
+def batches(iterable, batch_size):
+    iterator = iter(iterable)
+    while batch := list(islice(iterator, batch_size)):
+        yield batch
+
+
 def main(page: Page):
     page.title = "Flet icons browser"
     page.theme_mode = "light"
@@ -53,59 +61,59 @@ def main(page: Page):
     status_bar = Text()
 
     def copy_to_clipboard(e):
-        icon_key = e.control.data
-        print("Copy to clipboard:", icon_key)
-        page.clipboard = e.control.data
-        page.snack_bar = SnackBar(Text(f"Copied {icon_key}"), open=True)
-        page.update()
+        with page.lock:
+            icon_key = e.control.data
+            print("Copy to clipboard:", icon_key)
+            page.clipboard = e.control.data
+            page.snack_bar = SnackBar(Text(f"Copied {icon_key}"), open=True)
+            page.update()
+
+    def search_icons(search_term: str):
+        for icon_name in icons_list:
+            if search_term != "" and search_term in icon_name:
+                yield icon_name
 
     def display_icons(search_term: str):
 
         # clean search results
         search_results.clean()
 
-        # add matching icons
-        for i in range(0, len(icons_list)):
-            if search_term != "" and search_term in icons_list[i]:
-                icon_name = icons_list[i]
-                icon_key = f"icons.{icon_name.upper()}"
-                search_results.controls.append(
-                    TextButton(
-                        content=Container(
-                            content=Column(
-                                [
-                                    Icon(name=icon_name, size=30),
-                                    Text(
-                                        value=icon_name,
-                                        size=12,
-                                        width=100,
-                                        no_wrap=True,
-                                        text_align="center",
-                                        color=colors.ON_SURFACE_VARIANT,
-                                    ),
-                                ],
-                                spacing=5,
-                                alignment="center",
-                                horizontal_alignment="center",
+        for batch in batches(search_icons(search_term), 200):
+            with page.lock:
+                for icon_name in batch:
+                    icon_key = f"icons.{icon_name.upper()}"
+                    search_results.controls.append(
+                        TextButton(
+                            content=Container(
+                                content=Column(
+                                    [
+                                        Icon(name=icon_name, size=30),
+                                        Text(
+                                            value=f"{icon_name}",
+                                            size=12,
+                                            width=100,
+                                            no_wrap=True,
+                                            text_align="center",
+                                            color=colors.ON_SURFACE_VARIANT,
+                                        ),
+                                    ],
+                                    spacing=5,
+                                    alignment="center",
+                                    horizontal_alignment="center",
+                                ),
+                                alignment=alignment.center,
                             ),
-                            alignment=alignment.center,
-                        ),
-                        tooltip=f"{icon_key}\nClick to copy to a clipboard",
-                        on_click=copy_to_clipboard,
-                        data=icon_key,
+                            tooltip=f"{icon_key}\nClick to copy to a clipboard",
+                            on_click=copy_to_clipboard,
+                            data=icon_key,
+                        )
                     )
-                )
+                status_bar.value = f"Icons found: {len(search_results.controls)}"
+                page.update()
 
-                # update page on every 500 icons added
-                if i > 0 and i % 500 == 0:
-                    status_bar.value = f"Icons found: {len(search_results.controls)}"
-                    page.update()
-        status_bar.value = f"Icons found: {len(search_results.controls)}"
         if len(search_results.controls) == 0:
-            search_results.controls.append(
-                Text(f'No icons found with text "{search_term}".')
-            )
-        page.update()
+            page.snack_bar = SnackBar(Text("No icons found"), open=True)
+            page.update()
 
     def search_click(e):
         display_icons(search_txt.value)