feat(tui/login): add ctrl+v password visibility toggle#685
Merged
andrinoff merged 1 commit intofloatpane:masterfrom Apr 20, 2026
Merged
feat(tui/login): add ctrl+v password visibility toggle#685andrinoff merged 1 commit intofloatpane:masterfrom
andrinoff merged 1 commit intofloatpane:masterfrom
Conversation
github-actions
Bot
added
ci
Member
|
@mvanhorn remove the first commit. ( |
andrinoff
force-pushed
the
osc/593-password-visibility
branch
from
0b4bb57 to
e5a755a
Compare
Closes floatpane#593. Typos in app-passwords are hard to spot under EchoPassword and the workaround was to delete and retype. This wires ctrl+v (only while the password input has focus) to flip between EchoPassword and EchoNormal on inputs[inputPassword], matching the approach the issue suggested. The help line under the form already lists the other chord shortcuts (enter / tab / esc), so the new chord is appended to that same line and only while the password field is focused — keeps the hint discoverable without cluttering the view when focus is elsewhere. Go build, go vet, and go test ./tui all pass locally. Signed-off-by: drew <me@andrinoff.com>
andrinoff
force-pushed
the
osc/593-password-visibility
branch
from
e5a755a to
71f2390
Compare
Member
|
re-signed the commit. |
github-actions
Bot
added
ci
Contributor
Author
|
Thanks for landing the password visibility toggle, @andrinoff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #593.
Summary
Adds a
ctrl+vchord on the Password / App Password field intui/login.goto toggle betweentextinput.EchoPasswordandtextinput.EchoNormal. The chord only fires when the password input has focus; on any other field it falls through to normal input handling.When the password field is focused, the existing help line under the form adds
• ctrl+v: toggle password visibilityso the chord is discoverable without cluttering the view while other fields are focused.Why
Under
EchoPassword, typos in long app-passwords are effectively invisible. The previous workaround was to delete and retype carefully; this just reveals the masked characters in place.Implementation notes
EchoModeflip onm.inputs[inputPassword], which matches the approach the issue body proposed. Returnsm, nilso bubbletea doesn't also treat the chord as a regular keystroke into the input.ctrl+vwas picked for consistency with common TUIs and because matcha doesn't already bind it (grep confirmed).Verification
Manual check: running the login form, typing into the password field, pressing
ctrl+vflips the masked dots to plain text. Pressing again re-masks. Focus changes don't leak the reveal into other fields.AI assistance
This contribution was developed with AI assistance (Claude Code). Per matcha's
AI Policy: I understand what was submitted, the change was verified viago build,go vet, andgo test ./tui/, and the manual-check bullet above was the hands-on confirmation. No AI-generated tests were added for coverage padding.