Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry Template Definition #1573

Closed
norberttech opened this issue Apr 3, 2025 · 0 comments · Fixed by #1574
Closed

Entry Template Definition #1573

norberttech opened this issue Apr 3, 2025 · 0 comments · Fixed by #1574
Assignees

Comments

@norberttech
Copy link
Member

Due to how TValue and TType is defined on Entry interface more strict settings of phpstan will report following error:

         Parameter #1 ...$entry of function Flow\ETL\DSL\row expects Flow\ETL\Row\Entry<mixed, mixed>, Flow\ETL\Row\Entry\StringEntry given.          
         🪪  argument.type                                                                                                                            
         💡 Template type TValue on class Flow\ETL\Row\Entry is not covariant. Learn more: https://phpstan.org/blog/whats-up-with-template-covariant  
         💡 Template type TType on class Flow\ETL\Row\Entry is not covariant. Learn more: https://phpstan.org/blog/whats-up-with-template-covariant   
@norberttech norberttech self-assigned this Apr 3, 2025
@norberttech norberttech moved this to Todo in Roadmap Apr 3, 2025
@norberttech norberttech moved this from Todo to In Progress in Roadmap Apr 3, 2025
@norberttech norberttech linked a pull request Apr 3, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant