Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Support for Vim signs #22

Open
bookercodes opened this issue Apr 2, 2016 · 15 comments
Open

Support for Vim signs #22

bookercodes opened this issue Apr 2, 2016 · 15 comments

Comments

@bookercodes
Copy link

What do you think about using Signs to indicate erroneous lines?

(Screenshot taken from Syntatic)

@orlando
Copy link

orlando commented May 6, 2016

@alexbooker is this easy to integrate?. window split is a pain on a macbook pro 13 inch

@bookercodes
Copy link
Author

@orlando I'm never tried so I don't know.

I use Atom when I use Flow nowadays.

@orlando
Copy link

orlando commented May 6, 2016

@alexbooker cool, I'll give a try next week to see if I can come up with something.

Thanks!

@bookercodes
Copy link
Author

@orlando Sounds awesome 😄

I would just be a bit wary of the fact that the maintainers of this repository might not want to merge such a feature.

@orlando
Copy link

orlando commented Jun 4, 2016

@alexbooker I was about to start work on this, but looks like Syntastic already supports it. Just add it to your javascript checkers (let g:syntastic_javascript_checkers = ['eslint', 'flow']) and that's it.

So I think we should close this issue

@andreypopp
Copy link

Same for neomake, it works well with flow.

@bookercodes
Copy link
Author

Since I posted this two months ago I haven't really used vim-flow. Instead I use Atom so I'm not in a good position to comment.

@ryyppy
Copy link

ryyppy commented Aug 17, 2016

Neomake does this really really well!

@rafaelrinaldi
Copy link

rafaelrinaldi commented Dec 20, 2016

@ryyppy That's true, I'm delegating this to Neomake and it just works. Do you think is even worth having this plugin handling both linting and syntax highlighting? Maybe it's better to just take care of the latter and then suggesting other tools like syntastic and Neomake for linting, since they're out there for longer therefore are more reliable options.

@orlando
Copy link

orlando commented Dec 20, 2016

@ryyppy how do you set up neovim to do that. I want to switch to Neovim starting next month and this is one of the features I want to get in place from the beginning.

@rafaelrinaldi
Copy link

@orlando Neomake comes with Flow support. You just have to make sure you setup flow as a maker.

@orlando
Copy link

orlando commented Dec 20, 2016

@rafaelrinaldi

You just have to make sure you setup flow as a maker.

can you explain that part please?. I didn't get it

@rafaelrinaldi
Copy link

@orlando Something like this should do it:

" Disable Facebook's Flow Vim linter to avoid collisions
let g:flow#enable = 0

" Enable Flow maker
let g:neomake_javascript_enabled_makers = ['flow']

" Lint whenever saving a file
au BufWritePost * Neomake

@rafaelrinaldi
Copy link

@orlando I just wrote a more detailed explanation here.

@orlando
Copy link

orlando commented Dec 20, 2016

@rafaelrinaldi awesome. Great idea to have a til repo

Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants