-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set log_path in system config #4418
Comments
I don't know why system_config does not have |
I think this is the main case now.
|
@daipom is this still active or the ENV variable method is your proposed fix? |
@Athishpranav2003 Sorry for my late response.
The reason would be that Fluentd needs to know the path before parsing the config file. It would be convenient if we could specify the path in the config file, but then there would be the problem of how to handle the logs before parsing. If we can come up with a good solution, we can improve it, but if not, I don't see the need to force it. |
Oh i see. It makes sense that the parsing logs are also crucial and they seem to create a problem here. I am currently not sure of any sol but maybe there is some way to tackle this. Ideally we can solve this by having a default logging destination and change that+copy the initial logs to the configured directory once its obtained. Idk what issues might occur in this case |
Is your feature request related to a problem? Please describe.
I'm setting up AWX to install FluentD on VMs (not in Containers). Ansible's "ansible.builtin.service" doesn't have command line arguments like "-o" because it's using systemctl. So the logs can only be defaulted to /var/log.
Describe the solution you'd like
I'd simply like "log_path" to be an attribute I can set in the section of FluentD's config file. It's an attribute that can be set with command line arguments, but not in the config file.
Describe alternatives you've considered
I could modify the service file to include the "-o" command line argument, or have Ansible modify the code directly like in the system_config.rb file and so on so that attribute becomes available. In either case though it would just be a hacky temporary solution.
Additional context
My /var/log directory is mounted to a low capacity drive because we expected to be able to store all fluent related data in our /opt directory. For now I can set the log rotation very tightly to keep it from filling up, but I think the log path being configurable in the global settings file is a deserving feature that I'm surprised doesn't exist already.
The text was updated successfully, but these errors were encountered: