Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/Reload without downtime #4624

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Aug 30, 2024

Which issue(s) this PR fixes:

What this PR does / why we need it:
See #4622.

Currently, support only in_tcp and in_udp.
It would be able to support in_syslog and in_forward as well.

Needs following:

Docs Changes:
TODO

Release Note:
TODO

TODO:

  • Summarize specifications.
  • Add a plugin to handle output and load
  • Detailed implementation
  • Tests
  • Document

To make it easier to re-use plugin shutdown process.

Signed-off-by: Daijiro Fukuda <[email protected]>
Add a new feature: Update/Reload without downtime.

1. The current supervisor receives a signal.
2. The current supervisor sends signals to its workers, and the
   workers stop all plugins that cannot run in parallel.
3. The current supervisor starts a new supervisor.
   * => Old processes and new processes run in parallel.
4. After the new supervisor and its workers start to work, the
   current supervisor and its workers stop.

ref: nginx's feature for upgrading on the fly

* http://nginx.org/en/docs/control.html#upgrade

Problem to solve:

Updating Fluentd or reloading a config causes downtime.
Plugins that receive data as a server, such as `in_udp`, `in_tcp`,
and `in_syslog`, cannot receive data during this time.
This means that the data sent by a client is lost during this
time unless the client has a re-sending feature.
This makes updating Fluentd or reloading a config difficult in
some cases.

Specific feature:

Run only limited Input plugins in parallel, such as `in_tcp`,
`in_udp`, and `in_syslog`.
Stop all plugins except those Input plugins, and prepare a
dedicated file buffer for Output.
After the new workers start, they load the file buffer and route
those events to the ROOT label.

Note: need treasure-data/serverengine#146

Signed-off-by: Daijiro Fukuda <[email protected]>
TODO: This patch should be removed. We need to make a specific
plugin for this feature.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom changed the title Restart without downtime Update/Restart without downtime Aug 30, 2024
@daipom daipom changed the title Update/Restart without downtime Update/Reload without downtime Aug 30, 2024
@daipom daipom self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update/Reload without downtime
1 participant