From d8d3fa508a4a682c44cf8497a85c04e8023a903e Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 00:59:47 -0400 Subject: [PATCH 01/13] wip --- .github/workflows/build.yaml | 3 ++- scipy-2023/Dockerfile | 2 +- scipy-2023/Dockerfile.ci | 24 ++++++++++++++++++++++++ scipy-2023/Makefile | 10 +++++++--- scipy-2023/README.md | 4 ++-- scipy-2023/requirements-ci.txt | 6 ++++++ scipy-2023/workflows/example_00_intro.py | 3 +-- 7 files changed, 43 insertions(+), 9 deletions(-) create mode 100644 scipy-2023/Dockerfile.ci create mode 100644 scipy-2023/requirements-ci.txt diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 320d9c1..53e866f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -64,7 +64,8 @@ jobs: flytectl demo start sleep 3 flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml - pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-latest workflows + make sandbox-docker-build + pyflyte register --image localhost:30000/flyte-conference-talks:scipy-2023-sandbox workflows - name: Last Test run: echo 'done' diff --git a/scipy-2023/Dockerfile b/scipy-2023/Dockerfile index 8a83f9d..9a4a2ce 100644 --- a/scipy-2023/Dockerfile +++ b/scipy-2023/Dockerfile @@ -18,7 +18,7 @@ ENV PATH="${VENV}/bin:$PATH" # Install Python dependencies COPY ./requirements.txt /root RUN pip install -r /root/requirements.txt -RUN pip install --force-reinstall git+https://github.com/flyteorg/flytekit@e7afdab8b +RUN pip install --force-reinstall git+https://github.com/flyteorg/flytekit@3006032 # Copy the code COPY . /root diff --git a/scipy-2023/Dockerfile.ci b/scipy-2023/Dockerfile.ci new file mode 100644 index 0000000..c058bf2 --- /dev/null +++ b/scipy-2023/Dockerfile.ci @@ -0,0 +1,24 @@ +# 🐳📦 Docker containers unlock OS-level reproducibility 🔄 +FROM python:3.10-slim-buster + +WORKDIR /root +ENV VENV /opt/venv +ENV LANG C.UTF-8 +ENV LC_ALL C.UTF-8 +ENV PYTHONPATH /root + +RUN apt-get update && apt-get install -y git build-essential + +ENV VENV /opt/venv + +# Virtual environment +RUN python3 -m venv ${VENV} +ENV PATH="${VENV}/bin:$PATH" + +# Install Python dependencies +COPY ./requirements-ci.txt /root +RUN pip install -r /root/requirements-ci.txt + +# Copy the code +COPY . /root + diff --git a/scipy-2023/Makefile b/scipy-2023/Makefile index 0804371..d6ac4c2 100644 --- a/scipy-2023/Makefile +++ b/scipy-2023/Makefile @@ -1,4 +1,8 @@ VERSION=$(shell git rev-parse HEAD | cut -c1-7) -docker-build-push: - bash ./docker_build_push.sh -r ghcr.io/flyteorg -a flyte-conference-talks -v scipy-2023-${VERSION} - bash ./docker_build_push.sh -r ghcr.io/flyteorg -a flyte-conference-talks -v scipy-2023-latest + +docker-build: + docker build --push --tag ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-${VERSION} . + docker build --push --tag ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-latest . + +sandbox-docker-build: + docker build --push . -f Dockerfile.ci -t localhost:30000/flyte-conference-talks:scipy-2023-sandbox diff --git a/scipy-2023/README.md b/scipy-2023/README.md index c3575e5..0a7d4c0 100644 --- a/scipy-2023/README.md +++ b/scipy-2023/README.md @@ -113,7 +113,7 @@ source ~/venvs/scipy-2023/bin/activate Install dependencies: ```bash -pip install -r requirements.txt +pip install -r requirements.txt flytekitplugins-envd pip install jupyter ipdb ``` @@ -151,7 +151,7 @@ Test the Flyte sandbox with: export IMAGE=ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-latest pyflyte run --remote \ - --image $IMAGE \ + --image $IMAGE workflows/example_00_intro.py training_workflow \ --hyperparameters '{"C": 0.01}' ``` diff --git a/scipy-2023/requirements-ci.txt b/scipy-2023/requirements-ci.txt new file mode 100644 index 0000000..cb70976 --- /dev/null +++ b/scipy-2023/requirements-ci.txt @@ -0,0 +1,6 @@ +dataclasses_json +flytekit @ git+https://github.com/flyteorg/flytekit@3006032 +grpcio==1.51.3 +palmerpenguins +pandas +scikit-learn diff --git a/scipy-2023/workflows/example_00_intro.py b/scipy-2023/workflows/example_00_intro.py index 1aefdd2..e2d6dc7 100644 --- a/scipy-2023/workflows/example_00_intro.py +++ b/scipy-2023/workflows/example_00_intro.py @@ -17,7 +17,7 @@ from sklearn.model_selection import train_test_split from sklearn.linear_model import LogisticRegression -from flytekit import task, workflow, LaunchPlan, CronSchedule +from flytekit import task, workflow, LaunchPlan, CronSchedule, ImageSpec try: from workflows import logger @@ -33,7 +33,6 @@ "body_mass_g", ] - @dataclass_json @dataclass class Hyperparameters: From 4a57822cf04f4f6e734d39c7bb56d1c709ce35ad Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 09:28:11 -0400 Subject: [PATCH 02/13] add flytekitplugins envd --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 53e866f..5a2e1f6 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -47,7 +47,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install -r requirements.txt + pip install -r requirements.txt flytekitplugins-envd pip install pytest pytest-xdist - name: Pip info From 79a335bd4a9795ab703be3b600036a33bfbd6392 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 09:55:02 -0400 Subject: [PATCH 03/13] wip --- .github/workflows/build.yaml | 3 +-- scipy-2023/Makefile | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 5a2e1f6..0eafb3f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -64,8 +64,7 @@ jobs: flytectl demo start sleep 3 flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml - make sandbox-docker-build - pyflyte register --image localhost:30000/flyte-conference-talks:scipy-2023-sandbox workflows + pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows - name: Last Test run: echo 'done' diff --git a/scipy-2023/Makefile b/scipy-2023/Makefile index d6ac4c2..e18f3c7 100644 --- a/scipy-2023/Makefile +++ b/scipy-2023/Makefile @@ -4,5 +4,5 @@ docker-build: docker build --push --tag ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-${VERSION} . docker build --push --tag ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-latest . -sandbox-docker-build: - docker build --push . -f Dockerfile.ci -t localhost:30000/flyte-conference-talks:scipy-2023-sandbox +ci-docker-build: + docker build --push . -f Dockerfile.ci -t ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci From eaf9dc592ea10fc68ad1eeaeee80985c2d01fb95 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 10:09:44 -0400 Subject: [PATCH 04/13] add back integration tests --- .github/workflows/build.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 0eafb3f..04f0be8 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -65,9 +65,6 @@ jobs: sleep 3 flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows - - - name: Last Test - run: echo 'done' - # - name: Integration Tests - # run: pytest tests/integration + - name: Integration Tests + run: pytest tests/integration From b8215a3dd390ea6978ead9eb35f243d1c8b73e04 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 10:34:30 -0400 Subject: [PATCH 05/13] debug --- .github/workflows/build.yaml | 3 +++ scipy-2023/tests/integration/test_workflows.py | 8 +++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 04f0be8..d8cc82f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -67,4 +67,7 @@ jobs: pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows - name: Integration Tests + env: + FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml + CI: 1 run: pytest tests/integration diff --git a/scipy-2023/tests/integration/test_workflows.py b/scipy-2023/tests/integration/test_workflows.py index d126c96..79abb56 100644 --- a/scipy-2023/tests/integration/test_workflows.py +++ b/scipy-2023/tests/integration/test_workflows.py @@ -29,6 +29,12 @@ else: config = Config.auto(CONFIG_PATH) +workflow_cases = ( + WORKFLOW_CASES[:1] + if int(os.environ.get("CI", 0)) + else WORKFLOW_CASES +) + remote = FlyteRemote( config=config, default_project="flytesnacks", @@ -36,7 +42,7 @@ ) -@pytest.mark.parametrize("wf_case", WORKFLOW_CASES) +@pytest.mark.parametrize("wf_case", workflow_cases) def test_workflow_remote(wf_case: WorkflowCase): for _ in range(60): # bypass issue where multiple remote objects are authenticating at the From b7b217c231e5ac3294a755c58989acc5c5db3df4 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 11:12:40 -0400 Subject: [PATCH 06/13] debug --- .github/workflows/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index d8cc82f..50a2668 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -70,4 +70,4 @@ jobs: env: FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml CI: 1 - run: pytest tests/integration + run: pytest -v -v -v -s tests/integration From 90093ccaf2ff2eb5123b6835e918aae17ff99c11 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 11:34:22 -0400 Subject: [PATCH 07/13] matrix --- .github/workflows/build.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 50a2668..5df840d 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -19,9 +19,9 @@ jobs: fail-fast: false matrix: workshop-dir: ["scipy-2023"] - python-version: ["3.9"] - # python-version: ["3.8", "3.9", "3.10", "3.11"] - # os: ["ubuntu-latest", "macos-latest", "windows-latest"] + # python-version: ["3.9"] + python-version: ["3.8", "3.9", "3.10", "3.11"] + os: ["ubuntu-latest", "macos-latest", "windows-latest"] env: @@ -66,8 +66,8 @@ jobs: flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows - - name: Integration Tests - env: - FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml - CI: 1 - run: pytest -v -v -v -s tests/integration + # - name: Integration Tests + # env: + # FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml + # CI: 1 + # run: pytest tests/integration From a8b3a19d54a2fd8e9c08eae51c47e7ec2e193902 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 12:57:16 -0400 Subject: [PATCH 08/13] fix typing Annotated --- scipy-2023/requirements-ci.txt | 1 + scipy-2023/requirements.txt | 1 + scipy-2023/workflows/example_03_plugins.py | 6 +++++- scipy-2023/workflows/example_07_caching.py | 7 ++++++- scipy-2023/workflows/example_10_flyte_decks.py | 13 ++++++------- 5 files changed, 19 insertions(+), 9 deletions(-) diff --git a/scipy-2023/requirements-ci.txt b/scipy-2023/requirements-ci.txt index cb70976..f611f48 100644 --- a/scipy-2023/requirements-ci.txt +++ b/scipy-2023/requirements-ci.txt @@ -4,3 +4,4 @@ grpcio==1.51.3 palmerpenguins pandas scikit-learn +typing_extensions diff --git a/scipy-2023/requirements.txt b/scipy-2023/requirements.txt index 5ecfea3..32754a7 100644 --- a/scipy-2023/requirements.txt +++ b/scipy-2023/requirements.txt @@ -14,5 +14,6 @@ pandas pyspark<3.4.0 scikit-learn torch --index-url https://download.pytorch.org/whl/cpu +typing_extensions wheel whylogs diff --git a/scipy-2023/workflows/example_03_plugins.py b/scipy-2023/workflows/example_03_plugins.py index 342c33b..d491954 100644 --- a/scipy-2023/workflows/example_03_plugins.py +++ b/scipy-2023/workflows/example_03_plugins.py @@ -2,7 +2,6 @@ import os from dataclasses import dataclass -from typing import Annotated import pandas as pd import pyspark.sql @@ -20,6 +19,11 @@ from workflows.example_00_intro import FEATURES, TARGET +try: + from typing import Annotated +except ImportError: + from typing_extensions import Annotated + @dataclass_json @dataclass diff --git a/scipy-2023/workflows/example_07_caching.py b/scipy-2023/workflows/example_07_caching.py index 7939ce5..8ee776a 100644 --- a/scipy-2023/workflows/example_07_caching.py +++ b/scipy-2023/workflows/example_07_caching.py @@ -1,7 +1,7 @@ """Recoverability: Caching for compute efficiency.""" from dataclasses import asdict -from typing import Annotated, List, Tuple +from typing import List, Tuple import numpy as np import pandas as pd @@ -12,6 +12,11 @@ from flytekit import task, workflow, dynamic, HashMethod, Resources +try: + from typing import Annotated +except ImportError: + from typing_extensions import Annotated + from workflows.example_06_reproducibility import ( get_data, diff --git a/scipy-2023/workflows/example_10_flyte_decks.py b/scipy-2023/workflows/example_10_flyte_decks.py index 7af3381..2698e74 100644 --- a/scipy-2023/workflows/example_10_flyte_decks.py +++ b/scipy-2023/workflows/example_10_flyte_decks.py @@ -1,20 +1,19 @@ """Auditability: Flyte Decks for Pipeline visibility.""" -from typing import Annotated - import pandas as pd from palmerpenguins import load_penguins +try: + from typing import Annotated +except ImportError: + from typing_extensions import Annotated + from workflows.example_00_intro import FEATURES, TARGET import whylogs as why from flytekit import task, workflow, Deck, Resources from flytekitplugins.deck import FrameProfilingRenderer -from flytekitplugins.whylogs.renderer import ( - WhylogsConstraintsRenderer, - WhylogsSummaryDriftRenderer, -) -from flytekitplugins.whylogs.schema import WhylogsDatasetProfileTransformer +from flytekitplugins.whylogs.renderer import WhylogsConstraintsRenderer from whylogs.core import DatasetProfileView from whylogs.core.constraints import ConstraintsBuilder from whylogs.core.constraints.factories import ( From c9ab0da63d161cc2e905d6fd1e84f7ff860b971a Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 13:14:49 -0400 Subject: [PATCH 09/13] debug --- .github/workflows/build.yaml | 23 ++++++++++++++++++++--- scipy-2023/workflows/example_00_intro.py | 2 +- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 5df840d..feda946 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -62,9 +62,26 @@ jobs: - name: Setup Flyte Sandbox run: | flytectl demo start - sleep 3 - flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml - pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows + + - name: Update Resources + uses: nick-fields/retry@v2 + with: + timeout_minutes: 10 + retry_wait_seconds: 15 + max_attempts: 10 + shell: pwsh + command: flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml + + - name: Setup Flyte Sandbox + env: + FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml + uses: nick-fields/retry@v2 + with: + timeout_minutes: 10 + retry_wait_seconds: 15 + max_attempts: 10 + shell: pwsh + command: pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows # - name: Integration Tests # env: diff --git a/scipy-2023/workflows/example_00_intro.py b/scipy-2023/workflows/example_00_intro.py index e2d6dc7..7f7f1bb 100644 --- a/scipy-2023/workflows/example_00_intro.py +++ b/scipy-2023/workflows/example_00_intro.py @@ -17,7 +17,7 @@ from sklearn.model_selection import train_test_split from sklearn.linear_model import LogisticRegression -from flytekit import task, workflow, LaunchPlan, CronSchedule, ImageSpec +from flytekit import task, workflow, LaunchPlan, CronSchedule try: from workflows import logger From d52f124990c627d0373467664b1706e6fb517ef6 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 13:28:59 -0400 Subject: [PATCH 10/13] debug --- .github/workflows/build.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index feda946..861e84b 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -70,9 +70,9 @@ jobs: retry_wait_seconds: 15 max_attempts: 10 shell: pwsh - command: flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml + command: cd ${{ matrix.workshop-dir }} && flytectl --config /home/runner/.flyte/config-sandbox.yaml update task-resource-attribute --attrFile cra.yaml - - name: Setup Flyte Sandbox + - name: Register Workflows env: FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml uses: nick-fields/retry@v2 @@ -81,7 +81,7 @@ jobs: retry_wait_seconds: 15 max_attempts: 10 shell: pwsh - command: pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows + command: cd ${{ matrix.workshop-dir }} && pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows # - name: Integration Tests # env: From edad4db0aa0242a9cc6818fa74a23688c7b6e693 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 13:50:15 -0400 Subject: [PATCH 11/13] add poll interval --- .github/workflows/build.yaml | 11 +++++----- .../tests/integration/test_workflows.py | 21 +++++++++++-------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 861e84b..3503e4b 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -48,6 +48,7 @@ jobs: run: | python -m pip install --upgrade pip pip install -r requirements.txt flytekitplugins-envd + pip install --force-reinstall git+https://github.com/flyteorg/flytekit@3006032 pip install pytest pytest-xdist - name: Pip info @@ -83,8 +84,8 @@ jobs: shell: pwsh command: cd ${{ matrix.workshop-dir }} && pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows - # - name: Integration Tests - # env: - # FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml - # CI: 1 - # run: pytest tests/integration + - name: Integration Tests + env: + FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml + CI: 1 + run: pytest tests/integration diff --git a/scipy-2023/tests/integration/test_workflows.py b/scipy-2023/tests/integration/test_workflows.py index 79abb56..ebc1e9a 100644 --- a/scipy-2023/tests/integration/test_workflows.py +++ b/scipy-2023/tests/integration/test_workflows.py @@ -8,6 +8,7 @@ import logging import os import time +from datetime import timedelta from flytekit.remote import FlyteRemote from flytekit.configuration import Config @@ -29,11 +30,13 @@ else: config = Config.auto(CONFIG_PATH) -workflow_cases = ( - WORKFLOW_CASES[:1] - if int(os.environ.get("CI", 0)) - else WORKFLOW_CASES -) +if int(os.environ.get("CI", 0)): + workflow_cases = WORKFLOW_CASES[:1] + poll_interval = timedelta(seconds=90) +else: + workflow_cases = WORKFLOW_CASES + poll_interval = None + remote = FlyteRemote( config=config, @@ -44,17 +47,17 @@ @pytest.mark.parametrize("wf_case", workflow_cases) def test_workflow_remote(wf_case: WorkflowCase): - for _ in range(60): + for _ in range(120): # bypass issue where multiple remote objects are authenticating at the # same time. try: flyte_wf = remote.fetch_workflow(name=wf_case.workflow.name) break - except OSError: - time.sleep(1) + except Exception: + time.sleep(5) execution = remote.execute(flyte_wf, inputs=wf_case.inputs) url = remote.generate_console_url(execution) logger.info(f"Running workflow {wf_case.workflow.name} at: {url}") - execution = remote.wait(execution) + execution = remote.wait(execution, poll_interval=poll_interval) assert execution.closure.phase == SUCCEED_STATUS From e8ace0157cb92bf160b161388cb072053bf21aea Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 14:25:13 -0400 Subject: [PATCH 12/13] update readme --- .github/workflows/build.yaml | 7 ------- scipy-2023/README.md | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 3503e4b..d8ec806 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -19,7 +19,6 @@ jobs: fail-fast: false matrix: workshop-dir: ["scipy-2023"] - # python-version: ["3.9"] python-version: ["3.8", "3.9", "3.10", "3.11"] os: ["ubuntu-latest", "macos-latest", "windows-latest"] @@ -83,9 +82,3 @@ jobs: max_attempts: 10 shell: pwsh command: cd ${{ matrix.workshop-dir }} && pyflyte register --image ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci workflows - - - name: Integration Tests - env: - FLYTECTL_CONFIG: /home/runner/.flyte/config-sandbox.yaml - CI: 1 - run: pytest tests/integration diff --git a/scipy-2023/README.md b/scipy-2023/README.md index 0a7d4c0..f009979 100644 --- a/scipy-2023/README.md +++ b/scipy-2023/README.md @@ -151,7 +151,7 @@ Test the Flyte sandbox with: export IMAGE=ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-latest pyflyte run --remote \ - --image $IMAGE + --image $IMAGE \ workflows/example_00_intro.py training_workflow \ --hyperparameters '{"C": 0.01}' ``` From 009f7b7969de1425b4cd7c387723a0fdd0ead478 Mon Sep 17 00:00:00 2001 From: cosmicBboy Date: Sun, 9 Jul 2023 14:53:55 -0400 Subject: [PATCH 13/13] add sandbox make command --- scipy-2023/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scipy-2023/Makefile b/scipy-2023/Makefile index e18f3c7..475e0a1 100644 --- a/scipy-2023/Makefile +++ b/scipy-2023/Makefile @@ -6,3 +6,6 @@ docker-build: ci-docker-build: docker build --push . -f Dockerfile.ci -t ghcr.io/flyteorg/flyte-conference-talks:scipy-2023-ci + +sandbox-docker-build: + docker build --push . -f Dockerfile.ci -t localhost:30000/flyte-conference-talks:scipy-2023-ci