Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core feature] Flyteadmin email publisher #3847

Closed
2 tasks done
pingsutw opened this issue Jul 7, 2023 · 4 comments
Closed
2 tasks done

[Core feature] Flyteadmin email publisher #3847

pingsutw opened this issue Jul 7, 2023 · 4 comments
Assignees
@pingsutw @Future-Outlier
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service

Comments

@pingsutw
Copy link
Member

pingsutw commented Jul 7, 2023

Motivation: Why do you think this is important?

Currently, FlyteaAmin sends an event to aws SNS first. (admin event publisher -> SNS -> SQS -> admin email processor)
We can have an admin email publisher, which directly sends the email without SNS/SQS, and we should only use it in the sandbox.

The new email publisher can be added to here

Goal: What should the final outcome look like, ideally?

We are able to use email/slack notifications in the sandbox.

Describe alternatives you've considered

Add aws sns / sqs config in the sandbox environment.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pingsutw pingsutw added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers flyteadmin Issue for FlyteAdmin Service and removed untriaged This issues has not yet been looked at by the Maintainers labels Jul 7, 2023
@pingsutw
Copy link
Member Author

pingsutw commented Jul 7, 2023 •
edited
Loading

cc @Hacker-Davinci would you like to work on it?

@Future-Outlier
Copy link
Member

Yes please give me a chance !

@Future-Outlier
Copy link
Member

I am interested at it !

@Future-Outlier
Copy link
Member

I've finished it, please review, thanks a lot !

flyteorg/flyteadmin#595

@Future-Outlier Future-Outlier mentioned this issue Aug 2, 2023
Merged
@pingsutw pingsutw closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pingsutw pingsutw

@Future-Outlier Future-Outlier

Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pingsutw @Future-Outlier