Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Support overriding task pod_template via with_overrides #5683

Open
2 tasks done
swarup-stripe opened this issue Aug 21, 2024 · 5 comments
Open
2 tasks done
Assignees
Labels
enhancement New feature or request flytekit FlyteKit Python related issue

Comments

@swarup-stripe
Copy link

Motivation: Why do you think this is important?

We use pod_template to specify things like node selectors and tolerations. However, this is specific to certain workflows that share the core training tasks with other workflows. This means we have to duplicate the task function for each type of override we require. If we can support pod_template in with_overrides, this would reduce a lot of toil since we can supply pod templates in a central location and override downstream tasks, similar to how we can do so for resources.

Goal: What should the final outcome look like, ideally?

The with_overrides function here should be able to take in a pod_template argument, similar to how it can take in requests and limits.

Describe alternatives you've considered

We've duplicated each training function for every variation of pod template we have. This isn't very scalable though, so it restricts users from using many different specifications for different workflows.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@swarup-stripe swarup-stripe added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Aug 21, 2024
Copy link

runllm bot commented Aug 21, 2024

Currently, with_overrides does not support overriding the pod_template parameter. It is designed to override resources like requests and limits (source). To achieve your goal, you would need to propose an enhancement to the Flyte project to include pod_template in the with_overrides function.

Would you like more details on how to propose this enhancement or any other specific part of this configuration?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@wild-endeavor wild-endeavor self-assigned this Aug 21, 2024
@wild-endeavor wild-endeavor added flytekit FlyteKit Python related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Aug 21, 2024
@arbaobao
Copy link

#take

@swarup-stripe
Copy link
Author

@arbaobao Thank you for picking this up!! Curious if there are any updates? 👀

@arbaobao
Copy link

@swarup-stripe I'm working on it, and it will be done in a few days.

@geekysuavo
Copy link

@arbaobao any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytekit FlyteKit Python related issue
Projects
Status: Assigned
Development

No branches or pull requests

4 participants