Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Pod Template support for init containers (ie. copilot) #5734

Closed
2 tasks done
Sovietaced opened this issue Sep 9, 2024 · 2 comments · Fixed by #5750
Closed
2 tasks done

[Core feature] Pod Template support for init containers (ie. copilot) #5734

Sovietaced opened this issue Sep 9, 2024 · 2 comments · Fixed by #5750
Assignees
Labels
enhancement New feature or request

Comments

@Sovietaced
Copy link
Contributor

Sovietaced commented Sep 9, 2024

Motivation: Why do you think this is important?

The copilot init container downloads task metadata and if this task metadata is hosted in an on premises data store requests may fail to the data store due to TLS verification issues. The only way to resolve this right now is with a custom copilot image but this could also be handled with a pod template that specifies root certificate volume mounts (as we already do for normal flyte task containers). I propose that we allow users to specify pod template configurations for init containers in the same way that we do for normal containers.

ie.

            volumeMounts:
              - name: my-cert-bundle
                readOnly: true
                mountPath: /etc/ssl/certs

Goal: What should the final outcome look like, ideally?

In our fork we modified pod_helper to look for an init container with the name default-init.

Describe alternatives you've considered

Forcing users to build custom images, however this may have limitations if those custom images also need arguments from environment variables.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Sovietaced Sovietaced added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Sep 9, 2024
@kumare3
Copy link
Contributor

kumare3 commented Sep 11, 2024

@Sovietaced how about always make the user provided init go first? But i like the idea of default-init. would you mind upstreaming this?

@Sovietaced
Copy link
Contributor Author

@Sovietaced how about always make the user provided init go first? But i like the idea of default-init. would you mind upstreaming this?

I can try and make the behavior similar to the regular containers, looking for user provided container and fall back to default.

@eapolinario eapolinario self-assigned this Sep 19, 2024
@eapolinario eapolinario removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants