Add pod template support for init containers #5750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5750 +/- ##
==========================================
+ Coverage 36.21% 36.23% +0.02%
==========================================
Files 1303 1303
Lines 109644 109674 +30
==========================================
+ Hits 39710 39744 +34
+ Misses 65810 65804 -6
- Partials 4124 4126 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
|
@eapolinario not sure why only Peeter and I were the only ones pinged for review on this, but it seems like someone from Devex should probably review the code changes, so I added you -- feel free to tag someone else in! |
|
@eapolinario this should be good for review |
eapolinario
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5734
Why are the changes needed?
In some cases it can be advantageous to apply pod templates to init containers like the copilot init container that downloads metadata.
What changes were proposed in this pull request?
Updates
copilot.goto return the name of the generated init container for plumbing and then also updatespod_helper.goto merge pod templates fields into init containers.How was this patch tested?
See unit tests.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link