Skip to content
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.

Cmd+S in macOS adds a new line at the end #10

Closed
onewildgamer opened this issue Jun 28, 2020 · 4 comments
Closed

Cmd+S in macOS adds a new line at the end #10

onewildgamer opened this issue Jun 28, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@onewildgamer
Copy link

Pressing Cmd+S in the VS Code after installing the extension adds a new line at the end of the file.

Screen Recording 2020-06-28 at 22.07.07.mov.zip

@jevakallio
Copy link
Contributor

Thanks for reporting! This is related to #3 and #5 and possibly addressed by PR #6.

I'm looking to get this fixed ASAP, but will need to setup a Windows environment for testing to ensure we don't break it on different platforms / edge cases.

@Georift
Copy link

Georift commented Jun 29, 2020

@jevakallio I have a Windows environment with this issue visible if you'd like me to test a branch.

Seen the PR. I'll give it a try now.

@jevakallio jevakallio added the bug Something isn't working label Jun 29, 2020
@YashKumarVerma
Copy link

Update: facing the same issue on Ubuntu 19.04 (ctrl+s adds a new line)

@jevakallio
Copy link
Contributor

jevakallio commented Jun 29, 2020

Thanks for reporting this! Fixed in v0.1.5, available in Marketplace.

Closing issue now, let me know if it still persists after the version update and we'll reopen. Remember to reload the VS Code window after updating the extension!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants