Inverted color variables: are these correct?

[hugopeek]

I was just comparing my custom variables with FUI core variables and noticed the following additions:

Fomantic-UI/src/themes/default/globals/site.variables

Lines 302 to 303 in f451d15

	@primaryTextColor : @invertedTextColor;
	@secondaryTextColor : @invertedTextColor;

I'm a little confused by them being inverted... Logically, I would expect these variables to be primaryColor and secondaryColor, so they match the rest of the list (all dark colors). Setting them to primary and secondary also doesn't seem to change anything for me. I found references in label and button components, but they still look the same, whatever I enter there. The colors.less file also uses them but again, I can't figure out how or where.

So not really an issue, just wondering what they are doing.

For reference, these variables were introduced here:

7338ad2#diff-7124c2e79f2279a834c8ce10fcfb9c7727c91770bc49cae2427f22b6609f4585

[lubber-de]

primaryColor and secondaryColor are (unfortunately) often used for background colors and are dark (black and blue),

Fomantic-UI/src/themes/default/globals/site.variables

Lines 56 to 60 in f451d15

	@primaryColor : @blue;
	@secondaryColor : @black;
	@lightPrimaryColor : @lightBlue;
	@lightSecondaryColor : @lightBlack;

so the primaryTextColor and secondaryTextColor (used inside buttons/labels) cannot be the same. The desired color is white, that's why we have choosen to use invertedTextColor here

They are defined as text colors, which is used inside buttons/labels in the central colors.less file here

Fomantic-UI/src/themes/default/globals/colors.less

Line 14 in f451d15

text : @primaryTextColor;

I have to admit, this is somewhat inconsistent and would need a cleanup over all components...