Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[slider] in certain circumstances labels are overlapping, calculation of gapRatio goes wrong #3103

Open
Inselhopper opened this issue Sep 30, 2024 · 1 comment
Open

[slider] in certain circumstances labels are overlapping, calculation of gapRatio goes wrong #3103

Inselhopper opened this issue Sep 30, 2024 · 1 comment
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.9.4

Comments

@Inselhopper
Copy link
Contributor

Inselhopper commented Sep 30, 2024 •
edited
Loading

Bug Report

Slider with Labels
You can see this if you use a prime number. https://jsfiddle.net/inselhopper/uczsp3w6/14/

Steps to reproduce

  1. choose a big number for max
  2. choose a reuslting numLabels that is a prome number, e.g. 97

Expected result

I was expecting no overlapping of the labels and a calculation so half ticks with no labels are displayed

Actual result

labels are overlapping

Testcase

https://jsfiddle.net/inselhopper/uczsp3w6/14/

Version

2.9.3

My Pull Request see #3100
@Inselhopper Inselhopper added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Sep 30, 2024
@Inselhopper Inselhopper mentioned this issue Sep 30, 2024
Closed
@lubber-de lubber-de removed the state/awaiting-triage Any issues or pull requests which haven't yet been triaged label Sep 30, 2024
@lubber-de lubber-de mentioned this issue Oct 23, 2024
Merged
@lubber-de
Copy link
Member

lubber-de commented Oct 23, 2024 •
edited
Loading

I fixed this using a different approach via #3111
See your adjusted jsfiddle here https://jsfiddle.net/lubber/dgy8fe0j/1/

@lubber-de lubber-de added state/has-pr An issue which has a related PR open and removed state/awaiting-investigation Anything which needs more investigation labels Oct 23, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Oct 23, 2024
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.9.4
Development

No branches or pull requests
2 participants
@Inselhopper @lubber-de