font.renameGlyph() does not rename components

[khaledhosny]

I’m not sure if this is intentional, but font.renameGlyph() leave components with baseGlyph using the old name.

[madig]

I remember this also being an issue with TruFont/defcon but I can't remember.

[anthrotype]

yes I think we should support renaming components as well.

glifLib's GlyphSet has a getComponentReferences method that returns a dict keyed by composite glyph names pointing to lists of base component names (empty lists for simple glyphs).
(defcon exposes that as componentReferences property for Layer and Font classes so we may wish to do the same in ufoLib2)
These component references are basically a directed graph which we can reverse to obtain for each component glyph a list of composite glyphs that reference it. Then we can rename not only the single glyph but also, if it's used as a component, its Component.baseGlyph attribute for all the composite glyphs that references it.

[anthrotype]

a directed graph which we can reverse

by traversing the graph while building a new one with edges reversed

def reverse_graph(g):
    rev = {}
    for v in g:
        for e in g[v]:
            rev.setdefault(e, []).append(v)
    return rev

[anthrotype]

and we should probably cache these so that we don't have to rebuild every time we rename one glyph

[madig]

Which would mean that now we have to manage the cache. I think we're veering dangereously close to defcon territory here.

[anthrotype]

Hm yeah
How about a new renameGlyphs method that takes a mapping from old to new names and does the renaming in batch so that we compute the component graph only once?

[khaledhosny]

How about a new renameGlyphs method that takes a mapping from old to new names and does the renaming in batch so that we compute the component graph only once?

That would be best. I currently do this (names is a dict mapping old to new names):

for name in list(font.keys()):
    new = names.get(name)
    if new and new != name:
        font.renameGlyph(name, new)

for glyph in font:
    for component in glyph.components:
        name = component.baseGlyph
        new = names.get(name)
        if new and new != name:
            component.baseGlyph = new

[NightFurySL2001]

This would certainly be helpful.