Quick fixes (#171)

* quickfix: allSettled

* warning from node

* oops i mean warn

* const result

* log stack

Author: Mike Senn

api/modules/GithubEvents/index.js

@@ -91,7 +91,7 @@ class GithubEvents extends EventEmitter {
         });
 
         const rejected = [];
-        for (result of Promise.allSettled(handlerPromises)) {
+        for (const result of await Promise.allSettled(handlerPromises)) {
             if (result.status === 'rejected') {
                 rejected.push(result.reason);
                 logger.error('Handler rejected', result.reason);

app.js

@@ -74,3 +74,8 @@ sails.lift(rc('sails'));
 process.on('unhandledRejection', (error, promise) => {
     logger.error('Unhandled Promise Rejection', promise, error);
 });
+
+process.on('warning', error => {
+    // if error has a stack trace, it will be printed
+    logger.warn(`Warning from Node: ${error}`, error);
+});