Skip to content

Inner keys - the keys of "items_dict" should be a frozenset not a tuple #8

@jsbueno

Description

@jsbueno

The main motivation for this is that in the current API in order to update an item, one has to supply all its keys - there is no motive for all the keys to have to be in order.
Using frozenset should also be more efficient, but those gains should be marginal.

However, this change could break some backwards compatibility for the "get_other_keys" method if someone is expecting the key order to be maintained there (however, there is no such order promise, since the result for that function is a rebuilt list, not the key-tuple currently used as key) - I think the return type for it should be a frozeset instead of a list as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions