-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translating FormEdit #522
Comments
PRs are welcome, but this library is a wrapper around our core Javascript renderer, any translations (including labels) already occur there. If there's a specific issue you're running into, please provide a minimally reproducible example. Thanks! |
The Minimally reproducible example: User of this library can not translate the label Title, which is rendered by the |
Ah, I see what you mean. Yeah, I'd happily review a PR for this. |
Please review the PR I made. |
hey @PatrikTrefil see my comments |
Thank you for your contribution. As this issue has been inactive for over 90 days, I will close it for now. If you'd like to reopen the issue, please reply and we can resume the triage process. |
Labels in FormEdit such as this one should be passed through i18next to allow for translations. The same goes for placeholder values.
I am willing to make a PR. I just need confirmation that this change is desired.
The text was updated successfully, but these errors were encountered: