Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating FormEdit #522

Closed
PatrikTrefil opened this issue Jul 25, 2023 · 6 comments · May be fixed by #538
Closed

Translating FormEdit #522

PatrikTrefil opened this issue Jul 25, 2023 · 6 comments · May be fixed by #538

Comments

@PatrikTrefil
Copy link

Labels in FormEdit such as this one should be passed through i18next to allow for translations. The same goes for placeholder values.

I am willing to make a PR. I just need confirmation that this change is desired.

@brendanbond
Copy link
Contributor

PRs are welcome, but this library is a wrapper around our core Javascript renderer, any translations (including labels) already occur there. If there's a specific issue you're running into, please provide a minimally reproducible example. Thanks!

@PatrikTrefil
Copy link
Author

The FormEdit component renders a FormBuilder and some extra input fields such as Title, Path, etc. The extra fields can't be translated. As you can see on this line the label has value "Title", which is a string constant rather than something passed through an internalization library.

Minimally reproducible example: User of this library can not translate the label Title, which is rendered by the FormEdit component (this is not handled by the core JS render).

@brendanbond
Copy link
Contributor

Ah, I see what you mean. Yeah, I'd happily review a PR for this.

@PatrikTrefil
Copy link
Author

Please review the PR I made.

@brendanbond
Copy link
Contributor

hey @PatrikTrefil see my comments

@olgabann
Copy link

olgabann commented Sep 4, 2024

Thank you for your contribution. As this issue has been inactive for over 90 days, I will close it for now. If you'd like to reopen the issue, please reply and we can resume the triage process.

@olgabann olgabann closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants