Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(forge bind): add more derives to generated bindings #10097

Closed
pistomat opened this issue Mar 17, 2025 · 3 comments · Fixed by #10099
Closed

feat(forge bind): add more derives to generated bindings #10097

pistomat opened this issue Mar 17, 2025 · 3 comments · Fixed by #10099
Assignees
@pistomat
Labels
C-forge Command: forge Cmd-forge-bind Command: forge bind T-feature Type: feature

Comments

@pistomat
Copy link
Contributor

Component

Forge

Describe the feature you would like

forge bind does not allow generating extra derives at this moment. There is an obsolete option skip_extra_derives that I guess used to be a flag to derive all the other derives (i.e. enable the all_derives option in the alloy sol macro.

foundry/crates/forge/bin/cmd/bind.rs

Line 80 in 1c185d1

skip_extra_derives: bool,

This is the place where it should be probably inserted:

foundry/crates/sol-macro-gen/src/sol_macro_gen.rs

Line 92 in 1c185d1

#[sol(rpc, alloy_sol_types = alloy::sol_types, alloy_contract = alloy::contract)]

Additional context

No response
@pistomat pistomat added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Mar 17, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Mar 17, 2025
@pistomat
Copy link
Contributor Author

I am eager to make a PR for this, it is pretty straightforward. Without it I am currently forking this repo, but I would like to upstream the changes.

Let me know if I should go ahead with creating a PR for it.

@yash-atreya
Copy link
Member

Please go ahead and make the PR for this. Thanks.

@zerosnacks zerosnacks changed the title Add more derives to forge generated bindings feat(forge bind): add more derives to generated bindings Mar 17, 2025
@zerosnacks zerosnacks added C-forge Command: forge Cmd-forge-bind Command: forge bind and removed T-needs-triage Type: this issue needs to be labelled labels Mar 17, 2025
@pistomat pistomat mentioned this issue Mar 17, 2025
Merged
3 tasks
@pistomat
Copy link
Contributor Author

@yash-atreya PR here #10099 let me know what you think

@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pistomat pistomat

Labels
C-forge Command: forge Cmd-forge-bind Command: forge bind T-feature Type: feature
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use the unused skip_extra_derives bind argument pistomat/foundry
3 participants
@pistomat @yash-atreya @zerosnacks