Skip to content

Add option to return account address along with signature on cast wallet sign #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wavey0x opened this issue Apr 5, 2025 · 3 comments
Closed
Labels
T-feature Type: feature T-needs-triage Type: this issue needs to be labelled

Comments

@wavey0x
Copy link

wavey0x commented Apr 5, 2025

Component

Cast

Describe the feature you would like

I am building a small wrapper around cast wallet for users to interface with the Safe multisig api. It uses the following two cast operations:

  • cast wallet sign to sign a payload
  • cast wallet address to get the address of the account that signed

... unfortunately, as a result, the user must input the same password consecutively - once for each operation.

Can we please have a new cast wallet sign option that allows optional returning both pieces of information in a single command?

Additional context

No response

@wavey0x wavey0x added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Apr 5, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Apr 5, 2025
@grandizzy
Copy link
Collaborator

@wavey0x wouldn't this work for you by setting it as an env var and passing it to commands?

@wavey0x
Copy link
Author

wavey0x commented Apr 10, 2025

@wavey0x wouldn't this work for you by setting it as an env var and passing it to commands?

Works, but don't want to force user to set cleartext env vars with highly sensitive passwords.

@zerosnacks
Copy link
Member

I think you should capture the password once in your program and then pass it along how you see fit using the --password flag.

cast wallet sign "hello" --keystore <keystore> --password <password>

I would like to avoid adding highly specific behavior that combines command invocations.

For now marking this as not planned

@zerosnacks zerosnacks closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-feature Type: feature T-needs-triage Type: this issue needs to be labelled
Projects
Status: Done
Development

No branches or pull requests

3 participants