Skip to content

feat(forge bind): add extra derives (specifically serde) to contract bindings #10317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sveitser opened this issue Apr 16, 2025 · 2 comments · Fixed by #10332
Closed

feat(forge bind): add extra derives (specifically serde) to contract bindings #10317

sveitser opened this issue Apr 16, 2025 · 2 comments · Fixed by #10332
Labels
Cmd-forge-bind Command: forge bind first issue A good way to start contributing T-feature Type: feature

Comments

@sveitser
Copy link

sveitser commented Apr 16, 2025 •
edited
Loading

Component

Forge

Describe the feature you would like

This used to be possible with ethers bindings after #5836 but I think it's no longer supported now that bindings are genreated with alloy.

Recently more derives traits were added in #10099 but I think serde traits are still missing.

Additional context

No response
@sveitser sveitser added T-feature Type: feature T-needs-triage Type: this issue needs to be labelled labels Apr 16, 2025
@github-project-automation github-project-automation bot moved this to Todo in Foundry Apr 16, 2025
@nadtech-hub
Copy link

May I take on it?

@DaniPopes DaniPopes added first issue A good way to start contributing Cmd-forge-bind Command: forge bind and removed T-needs-triage Type: this issue needs to be labelled labels Apr 16, 2025
@DaniPopes
Copy link
Member

This is straight forward to add, just a mapping of CLI flag to #![sol(extra_derives)].
This adds #[derive(Debug, Default, ...)] to all generated types, but it does increase compilation time.

@yash-atreya yash-atreya changed the title Add extra derives (specifically serde) to contract bindings feat(forge bind): add extra derives (specifically serde) to contract bindings Apr 17, 2025
@0xcomfycat 0xcomfycat mentioned this issue Apr 17, 2025
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Apr 18, 2025
@Brando753 Brando753 mentioned this issue Apr 24, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cmd-forge-bind Command: forge bind first issue A good way to start contributing T-feature Type: feature
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add serde derive to forge bind 0xcomfycat/foundry
3 participants
@sveitser @nadtech-hub @DaniPopes