Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify-bytecode tests depend on cast in forge crate #8856

Open
DaniPopes opened this issue Sep 12, 2024 · 1 comment
Open

verify-bytecode tests depend on cast in forge crate #8856

DaniPopes opened this issue Sep 12, 2024 · 1 comment
Labels
A-internals Area: internals A-testing Area: testing Cmd-forge-vb Command: forge verify-bytecode

Comments

@DaniPopes
Copy link
Member

Can't run cargo t / cargo nextest run on -p forge because verify-bytecode tests depend on the cast binary which may not be available
@zerosnacks zerosnacks added Cmd-forge-verify Command: forge verify-contract/check A-internals Area: internals Cmd-forge-vb Command: forge verify-bytecode and removed Cmd-forge-verify Command: forge verify-contract/check labels Sep 12, 2024
@yash-atreya yash-atreya added the A-testing Area: testing label Sep 13, 2024
@yash-atreya
Copy link
Member

cast etherscan-source can probably be replaced by forge clone && forge flatten. Will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-internals Area: internals A-testing Area: testing Cmd-forge-vb Command: forge verify-bytecode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yash-atreya @DaniPopes @zerosnacks