From 3cb22b173e12fd593026c95774df5a0fb922f1d9 Mon Sep 17 00:00:00 2001 From: mutesplash <49622611+mutesplash@users.noreply.github.com> Date: Fri, 13 Dec 2019 16:57:23 -0500 Subject: [PATCH 1/2] Make clang 8 happy "m_sasl.c:89:3: error: non-void function 'mr_authenticate' should return a value [-Wreturn-type]" --- modules/m_sasl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/m_sasl.c b/modules/m_sasl.c index 218913bdd..a616f6469 100644 --- a/modules/m_sasl.c +++ b/modules/m_sasl.c @@ -86,7 +86,7 @@ mr_authenticate(struct Client *client_p, struct Client *source_p, if (*parv[1] == ':' || strchr(parv[1], ' ')) { exit_client(client_p, client_p, client_p, "Malformed AUTHENTICATE"); - return; + return 0; } if(source_p->preClient->sasl_complete) From 3b0ed6dfc85283808154c1c1130951bf7037f0e9 Mon Sep 17 00:00:00 2001 From: mutesplash <49622611+mutesplash@users.noreply.github.com> Date: Fri, 13 Dec 2019 16:58:56 -0500 Subject: [PATCH 2/2] Make clang 8 happy m_cmessage.c:199:3: error: non-void function 'm_cmessage' should return a value [-Wreturn-type] m_cmessage.c:203:3: error: non-void function 'm_cmessage' should return a value [-Wreturn-type] --- modules/m_cmessage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/m_cmessage.c b/modules/m_cmessage.c index f5ac000c6..7873988af 100644 --- a/modules/m_cmessage.c +++ b/modules/m_cmessage.c @@ -196,11 +196,11 @@ m_cmessage(int p_or_n, enum message_type msgtype, call_hook(h_privmsg_user, &hdata); if (hdata.approved != 0) - return; + return 0; /* the hook may have killed them */ if (IsAnyDead(source_p)) - return; + return 0; sendto_anywhere_message(target_p, source_p, cmdname[msgtype], "%s", hdata.text);