feat: skip errors during import

skynet2 · skynet2 · commit 416042c42777 · 2026-02-21T17:04:36.000+01:00
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -19,7 +19,7 @@
     "@angular/platform-browser": "^19.0.0",
     "@angular/platform-browser-dynamic": "^19.0.0",
     "@angular/router": "^19.0.0",
-    "@buf/xskydev_go-money-pb.bufbuild_es": "^2.9.0-20250825232136-eed02e2e6afd.1",
+    "@buf/xskydev_go-money-pb.bufbuild_es": "^2.11.0-20260221154942-deaf287f58ff.1",
     "@bufbuild/buf": "^1.54.0",
     "@bufbuild/protobuf": "^2.9.0",
     "@bufbuild/protoc-gen-es": "^2.9.0",
diff --git a/frontend/src/app/pages/transactions/transactions-import.component.html b/frontend/src/app/pages/transactions/transactions-import.component.html
@@ -26,6 +26,11 @@
 
                     <p-checkbox id="chkbox4" [(ngModel)]="skipDuplicateReferenceCheck" [binary]="true" />
                     <label for="chkbox4">Skip Duplicate Reference Check</label>
+
+                    @if (!stagingMode) {
+                        <p-checkbox id="chkbox5" [(ngModel)]="skipValidationErrors" [binary]="true" />
+                        <label for="chkbox5">Skip Validation Errors</label>
+                    }
                 </div>
                 @if (this.isRawTextImport()) {
                     <p-iftalabel>
diff --git a/frontend/src/app/pages/transactions/transactions-import.component.ts b/frontend/src/app/pages/transactions/transactions-import.component.ts
@@ -51,6 +51,7 @@ export class TransactionsImportComponent {
     public skipRules: boolean = false;
     public treatDatesAsUtc: boolean = false;
     public skipDuplicateReferenceCheck: boolean = false;
+    public skipValidationErrors: boolean = false;
     public isLoading: boolean = false;
     public stagingMode: boolean = true;
 
@@ -180,12 +181,20 @@ export class TransactionsImportComponent {
                     skipRules: this.skipRules,
                     treatDatesAsUtc: this.treatDatesAsUtc,
                     skipDuplicateReferenceCheck: this.skipDuplicateReferenceCheck,
+                    skipValidationErrors: this.skipValidationErrors,
                     source: this.selectedSource,
                     content: contents
                 })
             );
 
-            const logText = `Imported ${result.importedCount} transaction(s).\nDuplicate transactions: ${result.duplicateCount}.\n`;
+            const parts = [
+                `Imported ${result.importedCount} transaction(s).`,
+                `Duplicate transactions: ${result.duplicateCount}.`,
+            ];
+            if (result.skippedCount > 0) {
+                parts.push(`Skipped (validation errors): ${result.skippedCount}.`);
+            }
+            const logText = parts.join('\n');
             this.textContent = logText;
             this.messageService.add({ severity: 'success', detail: logText });
         } catch (e) {
diff --git a/go.mod b/go.mod
@@ -4,7 +4,7 @@ go 1.24.0
 
 require (
 	buf.build/gen/go/xskydev/go-money-pb/connectrpc/go v1.19.1-20260221145631-b1f442f55195.2
-	buf.build/gen/go/xskydev/go-money-pb/protocolbuffers/go v1.36.11-20260221145631-b1f442f55195.1
+	buf.build/gen/go/xskydev/go-money-pb/protocolbuffers/go v1.36.11-20260221154942-deaf287f58ff.1
 	connectrpc.com/connect v1.19.1
 	connectrpc.com/grpcreflect v1.3.0
 	github.com/DATA-DOG/go-sqlmock v1.5.2
diff --git a/go.sum b/go.sum
@@ -3,8 +3,8 @@ al.essio.dev/pkg/shellescape v1.6.0 h1:NxFcEqzFSEVCGN2yq7Huv/9hyCEGVa/TncnOOBBeX
 al.essio.dev/pkg/shellescape v1.6.0/go.mod h1:6sIqp7X2P6mThCQ7twERpZTuigpr6KbZWtls1U8I890=
 buf.build/gen/go/xskydev/go-money-pb/connectrpc/go v1.19.1-20260221145631-b1f442f55195.2 h1:RKXNh2DP9OU7NJO1zIE7FPr1Hteg/5n5cKk0y7gDx3o=
 buf.build/gen/go/xskydev/go-money-pb/connectrpc/go v1.19.1-20260221145631-b1f442f55195.2/go.mod h1:VTTULP3xLDXiwW6AkXskKv7ZBgzqh4wgauKnA8Svumc=
-buf.build/gen/go/xskydev/go-money-pb/protocolbuffers/go v1.36.11-20260221145631-b1f442f55195.1 h1:TCX0BllmWXkSzbWvPtsD2a7FBELmFhX5NIX1B5Vf6HI=
-buf.build/gen/go/xskydev/go-money-pb/protocolbuffers/go v1.36.11-20260221145631-b1f442f55195.1/go.mod h1:h6BlZCpceFTRzghEP6LSlTeYkE05pzKfQCnRYsP4kDA=
+buf.build/gen/go/xskydev/go-money-pb/protocolbuffers/go v1.36.11-20260221154942-deaf287f58ff.1 h1:IFpF6B6xAmF2EdWX1P4KxwOfgADCpt8Gxplc5HAXO+Y=
+buf.build/gen/go/xskydev/go-money-pb/protocolbuffers/go v1.36.11-20260221154942-deaf287f58ff.1/go.mod h1:h6BlZCpceFTRzghEP6LSlTeYkE05pzKfQCnRYsP4kDA=
 cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
 connectrpc.com/connect v1.19.1 h1:R5M57z05+90EfEvCY1b7hBxDVOUl45PrtXtAV2fOC14=
 connectrpc.com/connect v1.19.1/go.mod h1:tN20fjdGlewnSFeZxLKb0xwIZ6ozc3OQs2hTXy4du9w=
diff --git a/pkg/importers/importer.go b/pkg/importers/importer.go
@@ -163,6 +163,7 @@ func (i *Importer) Import(
 		tx,
 		transactions.UpsertOptions{
 			SkipAccountSourceDestValidation: true,
+			SkipValidationErrors:            req.SkipValidationErrors,
 		},
 	)
 
@@ -177,6 +178,7 @@ func (i *Importer) Import(
 	return &importv1.ImportTransactionsResponse{
 		ImportedCount:  int32(len(transactionResp)),
 		DuplicateCount: int32(duplicateCount),
+		SkippedCount:   int32(len(allTransactions) - len(transactionResp)),
 	}, nil
 }
 
diff --git a/pkg/transactions/service.go b/pkg/transactions/service.go
@@ -328,6 +328,14 @@ func (s *Service) CreateBulkInternal(
 
 		newTx, err := s.ConvertRequestToTransaction(ctx, req.Req, req.OriginalTx)
 		if err != nil {
+			if opts.SkipValidationErrors {
+				zerolog.Ctx(ctx).Warn().
+					Err(err).
+					Str("title", req.Req.Title).
+					Msg("skipping transaction due to validation error")
+				continue
+			}
+
 			return nil, err
 		}
 
diff --git a/pkg/transactions/types.go b/pkg/transactions/types.go
@@ -17,4 +17,5 @@ type CalculateDailyStatRequest struct {
 
 type UpsertOptions struct {
 	SkipAccountSourceDestValidation bool
+	SkipValidationErrors            bool
 }

Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,7 @@ func (i *Importer) Import(`
`163`	`163`	`tx,`
`164`	`164`	`transactions.UpsertOptions{`
`165`	`165`	`SkipAccountSourceDestValidation: true,`
	`166`	`+ SkipValidationErrors: req.SkipValidationErrors,`
`166`	`167`	`},`
`167`	`168`	`)`
`168`	`169`
`@@ -177,6 +178,7 @@ func (i *Importer) Import(`
`177`	`178`	`return &importv1.ImportTransactionsResponse{`
`178`	`179`	`ImportedCount: int32(len(transactionResp)),`
`179`	`180`	`DuplicateCount: int32(duplicateCount),`
	`181`	`+ SkippedCount: int32(len(allTransactions) - len(transactionResp)),`
`180`	`182`	`}, nil`
`181`	`183`	`}`
`182`	`184`
Original file line number	Diff line number	Diff line change
`@@ -17,4 +17,5 @@ type CalculateDailyStatRequest struct {`
`17`	`17`
`18`	`18`	`type UpsertOptions struct {`
`19`	`19`	`SkipAccountSourceDestValidation bool`
	`20`	`+ SkipValidationErrors bool`
`20`	`21`	`}`