Skip to content

Commit ef5cfef

Browse files
skynet2claude
andcommitted
fix: use matching currency accounts in new format tests
The mock currency converter was being called unexpectedly because the expense account currency (UAH) didn't match the transaction currency (EUR/PLN). Use nil converter with matching currency accounts instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 621cc9b commit ef5cfef

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

pkg/importers/privat24_test.go

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,12 +1515,7 @@ func TestImportExpenseWithDoubleConversion(t *testing.T) {
15151515
}
15161516

15171517
func TestImportNewFormatExpense(t *testing.T) {
1518-
ctrl := gomock.NewController(t)
1519-
defer ctrl.Finish()
1520-
1521-
mockConverter := NewMockCurrencyConverterSvc(ctrl)
1522-
1523-
p := importers.NewPrivat24(importers.NewBaseParser(mockConverter, nil, nil))
1518+
p := importers.NewPrivat24(importers.NewBaseParser(nil, nil, nil))
15241519

15251520
uahAccount := &database.Account{
15261521
ID: 1,
@@ -1530,10 +1525,11 @@ func TestImportNewFormatExpense(t *testing.T) {
15301525
}
15311526
expenseAccount := &database.Account{
15321527
ID: 2,
1533-
Currency: "UAH",
1528+
Currency: "EUR",
15341529
Type: v1.AccountType_ACCOUNT_TYPE_EXPENSE,
1530+
Name: "_default_expense",
15351531
Flags: database.AccountFlagIsDefault,
1536-
AccountNumber: "_default_expense_uah",
1532+
AccountNumber: "_default_expense_eur",
15371533
}
15381534

15391535
data := []byte(`[3/10/2026 8:30 AM] PrivatBank: 50.00EUR Комуналка та Інтернет. Test Merchant
@@ -1562,25 +1558,29 @@ func TestImportNewFormatExpense(t *testing.T) {
15621558
}
15631559

15641560
func TestImportNewFormatMultipleMessages(t *testing.T) {
1565-
ctrl := gomock.NewController(t)
1566-
defer ctrl.Finish()
1567-
1568-
mockConverter := NewMockCurrencyConverterSvc(ctrl)
1569-
1570-
p := importers.NewPrivat24(importers.NewBaseParser(mockConverter, nil, nil))
1561+
p := importers.NewPrivat24(importers.NewBaseParser(nil, nil, nil))
15711562

15721563
uahAccount := &database.Account{
15731564
ID: 1,
15741565
Currency: "UAH",
15751566
AccountNumber: "4*03",
15761567
Type: v1.AccountType_ACCOUNT_TYPE_ASSET,
15771568
}
1578-
expenseAccount := &database.Account{
1569+
eurExpenseAccount := &database.Account{
15791570
ID: 2,
1580-
Currency: "UAH",
1571+
Currency: "EUR",
15811572
Type: v1.AccountType_ACCOUNT_TYPE_EXPENSE,
1573+
Name: "_default_expense",
15821574
Flags: database.AccountFlagIsDefault,
1583-
AccountNumber: "_default_expense_uah",
1575+
AccountNumber: "_default_expense_eur",
1576+
}
1577+
plnExpenseAccount := &database.Account{
1578+
ID: 3,
1579+
Currency: "PLN",
1580+
Type: v1.AccountType_ACCOUNT_TYPE_EXPENSE,
1581+
Name: "_default_expense",
1582+
Flags: database.AccountFlagIsDefault,
1583+
AccountNumber: "_default_expense_pln",
15841584
}
15851585

15861586
data := []byte(`[3/10/2026 8:30 AM] PrivatBank: 50.00EUR Комуналка та Інтернет. Test Merchant
@@ -1604,7 +1604,7 @@ func TestImportNewFormatMultipleMessages(t *testing.T) {
16041604
result, err := p.Parse(context.TODO(), &importers.ParseRequest{
16051605
ImportRequest: importers.ImportRequest{
16061606
Data: []string{string(data)},
1607-
Accounts: []*database.Account{uahAccount, expenseAccount},
1607+
Accounts: []*database.Account{uahAccount, eurExpenseAccount, plnExpenseAccount},
16081608
},
16091609
})
16101610

0 commit comments

Comments
 (0)