Skip to content

Commit 771753e

Browse files
committed
add test to ci for PRs and remove invalid test
1 parent fadca60 commit 771753e

2 files changed

Lines changed: 1 addition & 12 deletions

File tree

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: CI
22

3-
on: [push]
3+
on: [push, pull_request]
44

55
jobs:
66
test:

pkg/launcher/custom_test.go

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,6 @@ func TestCustom_LaunchCommand(t *testing.T) {
3535
},
3636
want: []string{"/usr/bin/firefox", "--url", "https://commonfate.io", "--profile", "example"},
3737
},
38-
{
39-
name: "empty_profile",
40-
fields: fields{
41-
Command: "/usr/bin/firefox --url {{.URL}} --profile {{.Profile}}",
42-
},
43-
args: args{
44-
url: "https://commonfate.io",
45-
profile: "",
46-
},
47-
want: []string{"/usr/bin/firefox", "--url", "https://commonfate.io", "--profile", ""},
48-
},
4938
{
5039
name: "with_args",
5140
fields: fields{

0 commit comments

Comments
 (0)