-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
countResponse and booleanResponse not splitted per ResultSet #129
Comments
This has been in discussion for a while & also is in line with the need to add an optional beacon identifier to each ResultsetInstance - the following from the presentation at ELIXIR AHM 2023 (this was not "formal" and the
So, yes; and I had also called before for (especially in the network context but in general, too) for ant response being a ResultSetRespones (w/ an optional response part) to allow "single Beacon, different dataset permissions" responses. |
Back to this statement:
Yes, this has come up before - granularity does not explicitly say one should not report per dataset (resultSet); however, currently AFAIK the |
HI @mbaudis, Let me know what you think. |
@costero-e Well, this looks1 per se correct - but
So since we have to take it as a given that we need an option for mixed responses, at least for larger network queries, we either need then another response type for those which is more permissive. And that can realistically be used for any response... I understand that it is good for explanations to have tightly defined schemas; "this beacon only provides up to Footnotes
|
Hi @mbaudis, ok, I have just added the YAML solution, here 3f9edbb. A bit more correct now! |
Network is not the same as Aggregator In reality you want to create aggregators with many different beacons, w/ different status of maintenance and content etc. And there are many explorative query scenarios where one just wants to fire off at least count queries etc. Yes, one could iterate through query-response-requery ... scenarios but that's e.g. not really nice over a UI and certainly against the "discovery" aspect. So if every beacon not responding with the requested resultSet type just gives an error this is not helpful, even for an overview. |
+1 for this or a similar solution, I've been writing network code for our own count beacons, but I don't have a way to serve a standard count response that shows a breakdown of counts for each beacon. So this is still an issue even without mixing granularities. We are also working on beacons with multiple datasets where a count-per-dataset response would probably be useful. |
Now that we are implementing beacons in different projects, we are facing the problem that count and boolean responses are always a result of the aggregation of the resultSets, but they never show the results splitted by resultSet. This makes impossible to know, for a client requesting a beacon that only allows boolean/count granularity, which are the datasets that are responding positively or negatively. As we can see in the resultSet response from the standards:
We believe this resultSet response should be naturally returned by any type of granularity, with results being exclusively for the record granularity and resultsCount for the count and record granularity.
I will work on a solution in the next days to have this implemented unless the opinion on this is mostly the contrary and I wanted to know what do you think.
Thanks,
Oriol
The text was updated successfully, but these errors were encountered: