Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response meta can't handle many filtering terms #176

Open
gsfk opened this issue Nov 6, 2024 · 2 comments
Open

Response meta can't handle many filtering terms #176

gsfk opened this issue Nov 6, 2024 · 2 comments

Comments

@gsfk
Copy link
Collaborator

gsfk commented Nov 6, 2024

Looking again at the response meta (see #55), it includes a receivedRequestSummary field that uses its own definition of filters that's not used anywhere else:

framework/src/common/beaconCommonComponents.yaml#/definitions/Filters:

Filters:
    description: >-
      Ontology based filters. A CURIE syntax is encouraged to be used.
    type: array
    items:
      type: string
    example:
      - BTO:0000199
      - PATO:0000383

This requires filters to be strings, when two of the three kinds of filtering terms are objects, not strings. I can flatten to string in the response of course, but this is not that useful and will be ugly (e.g. I may have to escape double quotes in the object).

Shouldn't this definition point somewhere else, for example framework/src/requests/filteringTerms.yaml ?

@gsfk gsfk added the Dev scout label Nov 6, 2024
@redmitry
Copy link
Collaborator

redmitry commented Nov 6, 2024

This is a very old story... 🤷
#107

Dmitry

@gsfk
Copy link
Collaborator Author

gsfk commented Nov 6, 2024

huh, thanks... I didn't think to look in prs for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants