Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setType parameter conflict in beaconResultsets-MAX-example.json and beaconResultsets.json file #177

Open
Deepthi-v-s opened this issue Nov 8, 2024 · 1 comment
Open

setType parameter conflict in beaconResultsets-MAX-example.json and beaconResultsets.json file #177

Deepthi-v-s opened this issue Nov 8, 2024 · 1 comment

Comments

@Deepthi-v-s
Copy link

Deepthi-v-s commented Nov 8, 2024 •
edited
Loading

For beaconResultsets section, "setType" parameter is mentioned in (https://github.com/ga4gh-beacon/beacon-v2/blob/main/framework/json/responses/sections/beaconResultsets.json) , but in the example for the same beaconResultsets (https://github.com/ga4gh-beacon/beacon-v2/blob/main/framework/json/responses/examples-sections/beaconResultsets-MAX-example.json) it is using "type" parameter . Can I please know which is the correct parameter to use?

Thanks & regards,
Deepthi
@mbaudis
Copy link
Member

mbaudis commented Nov 9, 2024

@Deepthi-v-s It should be setType. AFAIK some of the examples were drafted during the development for v2 and haven't always been adjusted. Thanks for the alert.

Example: https://progenetix.org/beacon/biosamples/?testMode=true

mbaudis added a commit that referenced this issue Nov 9, 2024
@mbaudis
type => set type in example
6044850 
This fixes a well hidden example. Thanks to @Deepthi-v-s for #177
@mbaudis mbaudis mentioned this issue Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbaudis @Deepthi-v-s