Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design verifier to work on pulled local copies #13

Open
mbaudis opened this issue Jul 14, 2022 · 0 comments
Open

Re-design verifier to work on pulled local copies #13

mbaudis opened this issue Jul 14, 2022 · 0 comments

Comments

@mbaudis
Copy link
Member

mbaudis commented Jul 14, 2022

As discussed in #12 (and in previous issues for the Beacon v2 sources, using relative links to individual Github schemas inside a given project may lead to inconsistent behaviour when resolving schemas, while using absolute URLs to GH raw files brings another level of maintenance headaches, binds the schema to the hosting service and makes schema extensions extremely complicated; but especially breaks use cases with limited or missing network I/O. Some note:

Having external URLs within schema makes it impossible to use within other programs directly. This is mainly due to security and we would typically block outbound connections from containers/clusters.
I like the idea of strictly local verification with zero HTTP calls to GitHub.
Originally posted by @anuradhawick in #12 (comment)

Proposal

  • re-design the verifier to (pull and) access local schema trees
  • review & revise $ref parameters in https://github.com/ga4gh-beacon/beacon-v2/ - which may include a rethinking of external schema $ref values (so far only VRS)
  • documentation about use...

Alternatively or as addition, we could provide fully de-referenced schemas for all entities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant