Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add new field resultsHandover to BeaconAlleleResponse #285

Open
sdelatorrep opened this issue May 2, 2019 · 3 comments
Open

Add new field resultsHandover to BeaconAlleleResponse #285

sdelatorrep opened this issue May 2, 2019 · 3 comments
Milestone

Comments

@sdelatorrep
Copy link
Contributor

This field will be used for handovers regarding the query response, not the Beacon (beaconHandover) or the dataset(s) (datasetHandover).

@sdelatorrep sdelatorrep added this to the spec 1.1.0 milestone May 2, 2019
@sdelatorrep sdelatorrep changed the title Add resultHandover Add new field resultHandover May 2, 2019
@sdelatorrep sdelatorrep changed the title Add new field resultHandover Add new field resultHandover to BeaconAlleleResponse May 2, 2019
@sdelatorrep sdelatorrep changed the title Add new field resultHandover to BeaconAlleleResponse Add new field resultsHandover to BeaconAlleleResponse May 2, 2019
@mbaudis
Copy link
Member

mbaudis commented May 14, 2019

@sdelatorrep @juhtornr As mentioned in the call, "results" is strange since the dataset responses/handovers are also results; there, the method name describes the scope...
Logically, one could useaggregateHandover, in contrast to the non-aggregate, dataset specific responses/handovers. Also, a Beacon response (i.e. the typical "exists") should be an aggregateResponse.

But I'm actually not sure about the need for a beaconHandover. I think information about the Beacon is served by beaconInfo; and currently a beaconResponse describes the aggregate result. Isn't it enough to have:

  • BeaconInfo
    • information about the Beacon, general features, supported protocols, version
  • BeaconResponse, BeaconHandover
    • aggregate responses, handovers (all matched rsids ...)
  • DatasetResponse, DatasetHandover
    • dataset specific ... etc.

WDYT?

@sdelatorrep
Copy link
Contributor Author

Hi @mbaudis, I'd keep the beaconHandover inside beaconAlleleResponse because it could be useful to provide some information (e.g. contact) without forcing the user to go (again) to the info endpoint to get it. It could be redundant in some cases but, IMO, it does not harm and provides flexibility to the implementer.

I agree that aggregateHandover sounds better than resultsHandover. Please, @jrambla, give your feedback regarding this.

@mbaudis
Copy link
Member

mbaudis commented May 21, 2019

@sdelatorrep @jrambla O.k., makes sense for that purpose (Beacon information). Then

Also, a Beacon response (i.e. the typical "exists") should be an aggregateResponse.

Do we want to implement this (& similar...)? One could still keep the legacy response, I guess, but have a clearer structure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants