Fix & test SSH Shell

[gaetanzanella]

The state management of the shell is unclear and the code is not tested

[cheyongzi]

@gaetanzanella I would like to ask a question, why some commands do not return any information？

[gaetanzanella]

Can you provide an example? @cheyongzi

[cheyongzi]

[cheyongzi]

[cheyongzi]

When I open terminal using requestShell, write some command readHandler not receiving callback

[gaetanzanella]

I would need a working sample code 😢
swift-ssh-client integrates docker test files. Could you try it?

[cheyongzi]

I provide you with a complete code sample
class ViewController: UIViewController {

private var connection: SSHConnection!

private var shell: SSHShell!

override func viewDidLoad() {
    super.viewDidLoad()
    
    let authentication: SSHAuthentication = .init(username: "monitor", method:.password(.init("iTermX2022_m")) , hostKeyValidation: .acceptAll())
    connection = SSHConnection(host: "zerg.zomind.tech", port: 22, authentication: authentication)
    connection.start(withTimeout: 10) { result in
        switch result {
        case .success(let success):
            print("connect success \(success)")
            self.connection.requestShell(withTimeout: 5) { result in
                switch result {
                case .success(let shell):
                    print("request shell success")
                    self.shell = shell
                    self.shell.readHandler = { data in
                        print("read data is \(String.init(data: data, encoding: .utf8))")
                    }
                case .failure(let failure):
                    print("request shell failure")
                }
            }
        case .failure(let failure):
            print("connect failed \(failure)")
        }
    }
}


@IBAction func executeCommand(_ sender: Any) {
    self.shell.write("who\n".data(using: .utf8)!) { result in
        switch result {
        case .success(let success):
            print("write command success \(success)")
        case .failure(let failure):
            print("write command failure \(failure)")
        }
    }
}

}

[gaetanzanella]

Hi @cheyongzi, I think this is expected.
who does not produce any output. You can reproduce the behavior by executing:

connection.execute("who\n", withTimeout: 3.0) { result in
    print(result.standardOutput) // nil
}

[cheyongzi]

I'm sorry,
self.shell.write("history \n".data(using: .utf8)!) { result in switch result { case .success(let success): print("write command success \(success)") case .failure(let failure): print("write command failure \(failure)") } }
this always return empty

[fooleryang]

I'm having the same problem, is there a solution?