Summary
Consolidate the priority-pathogen KeyValueSection onto the generic shared KeyValueSection so there is a single implementation.
Do this only after the site-split epic (#1246) has landed and closed — it is intentionally deferred so it doesn't expand that work.
Background
During the site split, the priority-pathogen entity-detail sections were moved out of packages/core into BRC:
- Priority-pathogen fork:
app/views/PriorityPathogenView/ui/Section/KeyValueSection/ — wraps findable-ui's GridPaperSection, carries its own KeyElType / KeyValueElType / ValueElType (Grid layout, BODY_400).
- Generic shared:
packages/core/views/EntityView/components/KeyValueSection/ — used by both sites' assembly-detail Sides; local StyledSection, EntityView/ui ElTypes (Stack layout, BODY_400_2_LINES).
These are two independent forks of the same concept. They diverged in code (wrapper component, ElType layout primitive, typography variant) but render effectively the same — same labels, same spacing (see screenshots on the ticket). Because the Priority Pathogen "details" block is a single section, wrapping it in the generic section behaves like a fluid paper around that one section — the same visual result.
Proposed work
- Replace the priority-pathogen
KeyValueSection usage (buildPriorityPathogenDetails in the BRC viewModelBuilders + priorityPathogenSideColumn config) with the generic packages/core/views/EntityView/components/KeyValueSection.
- Verify the Priority Pathogen details panel renders identically (labels, spacing, single-section fluid-paper wrapping).
- Delete the priority-pathogen
KeyValueSection fork and its now-orphaned local ElTypes.
- Confirm nothing else in
PriorityPathogenView/ui still depends on the removed fork.
Acceptance criteria
- Priority Pathogen details renders with the generic shared
KeyValueSection, visually unchanged.
- The forked
KeyValueSection + its local ElTypes are removed.
- Both sites build and pass tests.
Notes
Summary
Consolidate the priority-pathogen
KeyValueSectiononto the generic sharedKeyValueSectionso there is a single implementation.Do this only after the site-split epic (#1246) has landed and closed — it is intentionally deferred so it doesn't expand that work.
Background
During the site split, the priority-pathogen entity-detail sections were moved out of
packages/coreinto BRC:app/views/PriorityPathogenView/ui/Section/KeyValueSection/— wrapsfindable-ui'sGridPaperSection, carries its ownKeyElType/KeyValueElType/ValueElType(Grid layout,BODY_400).packages/core/views/EntityView/components/KeyValueSection/— used by both sites' assembly-detail Sides; localStyledSection,EntityView/uiElTypes (Stack layout,BODY_400_2_LINES).These are two independent forks of the same concept. They diverged in code (wrapper component, ElType layout primitive, typography variant) but render effectively the same — same labels, same spacing (see screenshots on the ticket). Because the Priority Pathogen "details" block is a single section, wrapping it in the generic section behaves like a fluid paper around that one section — the same visual result.
Proposed work
KeyValueSectionusage (buildPriorityPathogenDetailsin the BRC viewModelBuilders +priorityPathogenSideColumnconfig) with the genericpackages/core/views/EntityView/components/KeyValueSection.KeyValueSectionfork and its now-orphaned local ElTypes.PriorityPathogenView/uistill depends on the removed fork.Acceptance criteria
KeyValueSection, visually unchanged.KeyValueSection+ its local ElTypes are removed.Notes