From 2efdb1bfbe6c2479b96c36d507dab54c3b92f067 Mon Sep 17 00:00:00 2001
From: John Chilton <jmchilton@gmail.com>
Date: Fri, 16 Jun 2023 14:18:22 -0400
Subject: [PATCH] Marginally more storage selenium coverage.

---
 client/src/components/Masthead/QuotaMeter.vue    | 16 ++++++++++++++--
 .../User/DiskUsage/StorageDashboard.vue          |  2 ++
 client/src/utils/navigation/navigation.yml       |  8 ++++++++
 lib/galaxy_test/selenium/test_history_storage.py | 15 ++++++++++++++-
 4 files changed, 38 insertions(+), 3 deletions(-)

diff --git a/client/src/components/Masthead/QuotaMeter.vue b/client/src/components/Masthead/QuotaMeter.vue
index 067dd6427b94..fe63a219beae 100644
--- a/client/src/components/Masthead/QuotaMeter.vue
+++ b/client/src/components/Masthead/QuotaMeter.vue
@@ -1,12 +1,24 @@
 <template>
     <div>
         <div v-if="!hasQuota" class="quota-text d-flex align-items-center">
-            <b-link v-b-tooltip.hover.left to="/storage" :disabled="isAnonymous" class="ml-auto" :title="title">
+            <b-link
+                v-b-tooltip.hover.left
+                to="/storage"
+                :disabled="isAnonymous"
+                class="ml-auto"
+                :title="title"
+                data-description="storage dashboard link">
                 {{ usingString + " " + totalUsageString }}
             </b-link>
         </div>
         <div v-else class="quota-meter d-flex align-items-center">
-            <b-link v-b-tooltip.hover.left class="quota-progress" :disabled="isAnonymous" to="/storage" :title="title">
+            <b-link
+                v-b-tooltip.hover.left
+                class="quota-progress"
+                :disabled="isAnonymous"
+                to="/storage"
+                :title="title"
+                data-description="storage dashboard link">
                 <b-progress :max="100">
                     <b-progress-bar aria-label="Quota usage" :value="usage" :variant="variant" />
                 </b-progress>
diff --git a/client/src/components/User/DiskUsage/StorageDashboard.vue b/client/src/components/User/DiskUsage/StorageDashboard.vue
index d0614d5982f8..ea9e40496f38 100644
--- a/client/src/components/User/DiskUsage/StorageDashboard.vue
+++ b/client/src/components/User/DiskUsage/StorageDashboard.vue
@@ -48,6 +48,7 @@ function goToHistoriesOverview() {
         <disk-usage-summary class="m-3" />
         <icon-card
             class="mx-auto mb-3"
+            data-description="free space card"
             :title="texts.freeSpace.title"
             :description="texts.freeSpace.description"
             :icon="texts.freeSpace.icon"
@@ -56,6 +57,7 @@ function goToHistoriesOverview() {
 
         <icon-card
             class="mx-auto mb-3"
+            data-description="explore usage card"
             :title="texts.explore.title"
             :description="texts.explore.description"
             :icon="texts.explore.icon"
diff --git a/client/src/utils/navigation/navigation.yml b/client/src/utils/navigation/navigation.yml
index 7980ac2888fa..898f9858777e 100644
--- a/client/src/utils/navigation/navigation.yml
+++ b/client/src/utils/navigation/navigation.yml
@@ -47,6 +47,9 @@ masthead:
 
     logged_in_only: '.loggedin-only'
     logged_out_only: '.loggedout-only'
+    storage_dashboard_link:
+      selector: 'storage dashboard link'
+      type: data-description
 
   labels:
     # top-level menus
@@ -323,6 +326,11 @@ history_storage:
   selectors:
     _: '.history-storage-overview'
 
+storage_dashboard:
+  selectors:
+    free_space_link: '[data-description="free space card"] button'
+    explore_usage_link: '[data-description="explore usage card"] button'
+
 edit_dataset_attributes:
   selectors:
     database_build_dropdown: '[data-label="Database/Build"]'
diff --git a/lib/galaxy_test/selenium/test_history_storage.py b/lib/galaxy_test/selenium/test_history_storage.py
index f9fb2a7ce1aa..4128e1024d68 100644
--- a/lib/galaxy_test/selenium/test_history_storage.py
+++ b/lib/galaxy_test/selenium/test_history_storage.py
@@ -31,5 +31,18 @@ def test_history_storage(self):
         self.wait_for_history()
         self.components.history_panel.storage_overview.wait_for_and_click()
         self.components.history_storage._.wait_for_visible()
-        self.screenshot("history-storage")
+        self.screenshot("history_storage")
         self.components.history_storage._.assert_no_axe_violations_with_impact_of_at_least("critical")
+
+        self.home()
+        self.components.masthead.storage_dashboard_link.wait_for_and_click()
+        self.screenshot("storage_dashboard")
+        self.components.storage_dashboard.free_space_link.wait_for_and_click()
+        self.screenshot("storage_dashboard_manage_free_space_landing")
+        self.assert_baseline_accessibility()
+
+        self.home()
+        self.components.masthead.storage_dashboard_link.wait_for_and_click()
+        self.components.storage_dashboard.explore_usage_link.wait_for_and_click()
+        self.screenshot("storage_dashboard_manage_explore_usage_landing")
+        self.assert_baseline_accessibility()